8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual

[DougLea]

Accommodate compensations when checking for missed signals; add a better test for this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22543/head:pull/22543
$ git checkout pull/22543

Update a local copy of the PR:
$ git checkout pull/22543
$ git pull https://git.openjdk.org/jdk.git pull/22543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22543

View PR using the GUI difftool:
$ git pr show -t 22543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22543.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DougLea This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• bcd1018: 8344540: Remove superseded wildcard description from java manpage
• f3807d6: 8345403: Add more randomized tests to better cover FloatingDecimal parsing
• 3b7571d: 8345398: Avoid redundant Properties.containsKey call in Cursor.getSystemCustomCursor
• ca46c3a: 8343622: AesDkCrypto.stringToKey should not return null
• e46d822: 8345547: test/jdk/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java fails in ubuntu22.04
• 2331782: 8345179: RISC-V: Add gtests for weak cmpxchg
• 7c8cec1: 8345224: Test runtime/cds/appcds/applications/JavacBench.java#dynamic fails after JDK-8344822
• 77cfcee: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests
• 67a7b00: 8345355: [s390x] support for z16 hardware
• 9c3d3b9: 8345503: Test EnableNativeAccessCDS.java fails with TEST_THREAD_FACTORY=Virtual
• ... and 15 more: https://git.openjdk.org/jdk/compare/de3a218a2801b8a4b414fce9337bd151ded9b7f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DougLea The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (0f5d9651)
• 01: Full - Incremental (efc1e77d)
• 00: Full (dc88c881)

[viktorklang-ora]

Suggested change

	* @library /test/lib
	* @bug 8345294
	* @library /test/lib

[DougLea]

Done.

[viktorklang-ora]

Thanks for the fix, Doug, and thanks for the reproducer test, @AlanBateman!

Having a look at the patch now 👍

[AlanBateman]

At some point we can add @summary to the test as reminder of its purpose. Otherwise this looks good, and happy this was caught.

[DougLea]

/integrate

[openjdk]

Going to push as commit 92e9ac6.
Since your change was applied there have been 28 commits pushed to the master branch:

• b42d79e: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats
• 7ee84d8: 8345566: Deproblemlist test/jdk/javax/swing/JComboBox/6559152/bug6559152.java
• 01307a7: 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486
• bcd1018: 8344540: Remove superseded wildcard description from java manpage
• f3807d6: 8345403: Add more randomized tests to better cover FloatingDecimal parsing
• 3b7571d: 8345398: Avoid redundant Properties.containsKey call in Cursor.getSystemCustomCursor
• ca46c3a: 8343622: AesDkCrypto.stringToKey should not return null
• e46d822: 8345547: test/jdk/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java fails in ubuntu22.04
• 2331782: 8345179: RISC-V: Add gtests for weak cmpxchg
• 7c8cec1: 8345224: Test runtime/cds/appcds/applications/JavacBench.java#dynamic fails after JDK-8344822
• ... and 18 more: https://git.openjdk.org/jdk/compare/de3a218a2801b8a4b414fce9337bd151ded9b7f8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DougLea Pushed as commit 92e9ac6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.