Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345502: Remove doIntersectionPrivilege methods #22548

Closed
wants to merge 3 commits into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Dec 4, 2024

The internal ProtectionDomain.doIntersectionPrivilege methods can be removed as all dependencies have been removed in post JEP 486 cleanup issues.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345502: Remove doIntersectionPrivilege methods (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22548/head:pull/22548
$ git checkout pull/22548

Update a local copy of the PR:
$ git checkout pull/22548
$ git pull https://git.openjdk.org/jdk.git pull/22548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22548

View PR using the GUI difftool:
$ git pr show -t 22548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22548.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2024

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345502: Remove doIntersectionPrivilege methods

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 16ef6e2: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration
  • 923321c: 8345447: test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in ubuntu22.04
  • 6f30762: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@seanjmullan The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 4, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2024

Webrevs

@wangweij
Copy link
Contributor

wangweij commented Dec 4, 2024

I see in SharedSecrets these 2 imports are useless. Not sure if you want to take this chance to remove them as well.

import java.io.PrintStream;
import java.io.PrintWriter;

@seanjmullan
Copy link
Member Author

I see in SharedSecrets these 2 imports are useless. Not sure if you want to take this chance to remove them as well.

import java.io.PrintStream;
import java.io.PrintWriter;

Sure. Fixed.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 4, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@seanjmullan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit de3a218.
Since your change was applied there have been 9 commits pushed to the master branch:

  • faa109e: 8340580: Characters in Document diagrams not in the middle
  • 6aa7667: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache
  • e1695f6: 8345472: Fix incorrect format instruction for floating point max/min patterns
  • baa6957: 8345507: Fix build of static launcher
  • 79eb77b: 8345486: Reevaluate the classes in java.lang.classfile.components package
  • f3b4350: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling
  • 16ef6e2: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration
  • 923321c: 8345447: test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in ubuntu22.04
  • 6f30762: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@seanjmullan Pushed as commit de3a218.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants