8343890: SEGV crash in RunTimeClassInfo::klass

[matias9927]

Some tests fail very intermittently due to RuntimeInfo::klass(), see the bug page for more details. This patch modifies the method to avoid the reported crash. Verified with tier 1-5 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343890: SEGV crash in RunTimeClassInfo::klass (Bug - P3)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 25, a new backport will be created when this pr is integrated.)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22550/head:pull/22550
$ git checkout pull/22550

Update a local copy of the PR:
$ git checkout pull/22550
$ git pull https://git.openjdk.org/jdk.git pull/22550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22550

View PR using the GUI difftool:
$ git pr show -t 22550

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22550.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343890: SEGV crash in RunTimeClassInfo::klass

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• 5cc150c: 8342979: Start of release updates for JDK 25
• 85fedbf: 8344607: Link Time Optimization - basic support for clang
• 5a0899f: 8345302: Building microbenchmarks require larger Java heap
• 1ece4f9: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray
• ef8da28: 8345591: [aarch64] macroAssembler_aarch64.cpp compile fails ceil_log2 not declared
• 7513b13: 8328944: NMT reports "unknown" memory
• 691e692: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util
• 97b8a09: 8345339: JFR: Missing javadoc for RecordingStream::onMetadata
• 456c71d: 8343699: [aarch64] Bug in MacroAssembler::klass_decode_mode()
• 308357c: 8345578: New test in JDK-8343622 fails with a promoted build
• ... and 70 more: https://git.openjdk.org/jdk/compare/73b8b34a8c627dd31ee97f3a301bd9d92d7031ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b39c114d)

[iklam]

LGTM

[calvinccheung]

Looks good.

[matias9927]

Thanks for the reviews @calvinccheung and @iklam!
/integrate

[openjdk]

Going to push as commit bf0debc.
Since your change was applied there have been 83 commits pushed to the master branch:

• a97dca5: 8344593: GenShen: Review of ReduceInitialCardMarks
• bedb68a: 8342444: Shenandoah: Uncommit regions from a separate, STS aware thread
• dbf48a5: 8344665: Refactor PartialArrayState allocation for reuse
• 5cc150c: 8342979: Start of release updates for JDK 25
• 85fedbf: 8344607: Link Time Optimization - basic support for clang
• 5a0899f: 8345302: Building microbenchmarks require larger Java heap
• 1ece4f9: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray
• ef8da28: 8345591: [aarch64] macroAssembler_aarch64.cpp compile fails ceil_log2 not declared
• 7513b13: 8328944: NMT reports "unknown" memory
• 691e692: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util
• ... and 73 more: https://git.openjdk.org/jdk/compare/73b8b34a8c627dd31ee97f3a301bd9d92d7031ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@matias9927 Pushed as commit bf0debc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[matias9927]

/backport jdk jdk24

[openjdk]

@matias9927 the backport was successfully created on the branch backport-matias9927-bf0debc0-jdk24 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk24, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit bf0debc0 from the openjdk/jdk repository.

The commit being backported was authored by Matias Saavedra Silva on 5 Dec 2024 and was reviewed by Ioi Lam and Calvin Cheung.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-matias9927-bf0debc0-jdk24:backport-matias9927-bf0debc0-jdk24
$ git checkout backport-matias9927-bf0debc0-jdk24
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-matias9927-bf0debc0-jdk24

⚠️ @matias9927 You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.