-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8344461: Additional cleanup in NewThreadAction #22557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8344461: Additional cleanup in NewThreadAction #22557
Conversation
👋 Welcome back smarks! A progress list of the required criteria for merging this PR into |
/issue JDK-8344867 |
@stuart-marks This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 43 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@stuart-marks |
/contributor add RogerRiggs |
@stuart-marks Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
@stuart-marks The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/contributor add rriggs |
@stuart-marks |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the cleanup
@RogerRiggs Thanks, I'll integrate after internal testing run completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
/integrate |
Going to push as commit 8a3c100.
Your commit was automatically rebased without conflicts. |
@stuart-marks Pushed as commit 8a3c100. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Convert the RMI NewThreadAction class into a couple static methods on RuntimeUtil. Also remove a couple unnecessary qualified exports from java.base to java.rmi.
Progress
Issues
Reviewers
Contributors
<rriggs@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22557/head:pull/22557
$ git checkout pull/22557
Update a local copy of the PR:
$ git checkout pull/22557
$ git pull https://git.openjdk.org/jdk.git pull/22557/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22557
View PR using the GUI difftool:
$ git pr show -t 22557
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22557.diff
Using Webrev
Link to Webrev Comment