Skip to content

8344461: Additional cleanup in NewThreadAction #22557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Dec 4, 2024

Convert the RMI NewThreadAction class into a couple static methods on RuntimeUtil. Also remove a couple unnecessary qualified exports from java.base to java.rmi.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8344461: Additional cleanup in NewThreadAction (Bug - P4)
  • JDK-8344867: Cleanup unneeded qualified exports to java.rmi (Bug - P4)

Reviewers

Contributors

  • Roger Riggs <rriggs@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22557/head:pull/22557
$ git checkout pull/22557

Update a local copy of the PR:
$ git checkout pull/22557
$ git pull https://git.openjdk.org/jdk.git pull/22557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22557

View PR using the GUI difftool:
$ git pr show -t 22557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22557.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2024

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@stuart-marks
Copy link
Member Author

/issue JDK-8344867

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344461: Additional cleanup in NewThreadAction
8344867: Cleanup unneeded qualified exports to java.rmi

Co-authored-by: Roger Riggs <rriggs@openjdk.org>
Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • f904480: 8345512: Remove wrapper functions for intrinsics in PQC algorithms
  • 8d19a56: 8340359: Remove javax.naming.Context.APPLET
  • c113f82: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id
  • ea73e05: 8345181: (ch) Windows asynchronous channels may return temporary direct buffers to the buffer cache twice (win)
  • ee0f88c: 8341923: java.util.Locale class specification improvements
  • a72cab8: 8345148: Fix for JDK-8337317 is incomplete
  • 1a73c76: 8345524: CHECK_FOR_FILES should properly handle directories
  • 1d3dcdf: 8345433: (fs) Use stream to load FileTypeDetectors in Files.probeContentType
  • 9740c1d: 8333572: Update jpackage.md with info related to WiX v4 and v5 support
  • de3a218: 8345502: Remove doIntersectionPrivilege methods
  • ... and 33 more: https://git.openjdk.org/jdk/compare/05ee562a38bf7325becdd04f2e9d3238b95a4cb0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@stuart-marks
Adding additional issue to issue list: 8344867: Cleanup unneeded qualified exports to java.rmi.

@stuart-marks
Copy link
Member Author

/contributor add RogerRiggs

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@stuart-marks RogerRiggs was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 4, 2024
@stuart-marks
Copy link
Member Author

/contributor add rriggs

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@stuart-marks
Contributor Roger Riggs <rriggs@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2024

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the cleanup

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@stuart-marks
Copy link
Member Author

@RogerRiggs Thanks, I'll integrate after internal testing run completes.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 4, 2024
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@stuart-marks
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit 8a3c100.
Since your change was applied there have been 43 commits pushed to the master branch:

  • f904480: 8345512: Remove wrapper functions for intrinsics in PQC algorithms
  • 8d19a56: 8340359: Remove javax.naming.Context.APPLET
  • c113f82: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id
  • ea73e05: 8345181: (ch) Windows asynchronous channels may return temporary direct buffers to the buffer cache twice (win)
  • ee0f88c: 8341923: java.util.Locale class specification improvements
  • a72cab8: 8345148: Fix for JDK-8337317 is incomplete
  • 1a73c76: 8345524: CHECK_FOR_FILES should properly handle directories
  • 1d3dcdf: 8345433: (fs) Use stream to load FileTypeDetectors in Files.probeContentType
  • 9740c1d: 8333572: Update jpackage.md with info related to WiX v4 and v5 support
  • de3a218: 8345502: Remove doIntersectionPrivilege methods
  • ... and 33 more: https://git.openjdk.org/jdk/compare/05ee562a38bf7325becdd04f2e9d3238b95a4cb0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@stuart-marks Pushed as commit 8a3c100.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants