Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345335: Add excluded jdk_foreign tests to tier4 #22580

Conversation

frkator
Copy link
Member

@frkator frkator commented Dec 5, 2024

@AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore @JornVernee

adding as manual tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345335: Add excluded jdk_foreign tests to manual group (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22580/head:pull/22580
$ git checkout pull/22580

Update a local copy of the PR:
$ git checkout pull/22580
$ git pull https://git.openjdk.org/jdk.git pull/22580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22580

View PR using the GUI difftool:
$ git pr show -t 22580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22580.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2024

👋 Welcome back isipka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@frkator This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345335: Add excluded jdk_foreign tests to manual group

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

  • 2c4567a: 8342651: Refactor array constant to use an array of jbyte
  • 72c6daf: 8346007: Incorrect copyright header in UModLNodeIdealizationTests.java
  • cc47918: 8345040: Clean up unused variables and code in generate_native_wrapper
  • c34b87c: 8345659: Fix broken alignment after ReservedSpace splitting in GC code
  • e294899: 8345647: Fix recent NULL usage backsliding in Shenandoah
  • d381d58: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes
  • 45c914c: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • a21d21f: 8345609: [C1] LIR Operations with one input should be implemented as LIR_Op1
  • 2382a2d: 8345661: Simplify page size alignment in code heap reservation
  • 076bfa6: 8345656: Move os alignment functions out of ReservedSpace
  • ... and 72 more: https://git.openjdk.org/jdk/compare/ef8da28487f918c38fab3096eaeed572d5ea5b90...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@frkator The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 5, 2024
@frkator frkator changed the title 8345335: add excluded jdk_foreign tests to ATR job 8345335: Add excluded jdk_foreign tests to ATR job Dec 5, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2024

Webrevs

@frkator frkator changed the title 8345335: Add excluded jdk_foreign tests to ATR job 8345335: Add excluded jdk_foreign tests to manual groups Dec 5, 2024
@frkator frkator changed the title 8345335: Add excluded jdk_foreign tests to manual groups 8345335: Add excluded jdk_foreign tests to manual group Dec 5, 2024
@shurymury
Copy link
Contributor

LGTM

@frkator
Copy link
Member Author

frkator commented Dec 10, 2024

as per discussion with @JornVernee:

1 both tests declared as automatic
2 introduced new group called jdk_foreign_stress and added both tests to it
3 jdk_foreign_stress added to tier3 ( TestMatrix may run up to 40 mins)

cc @AlanBateman

Copy link
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for jdk_foreign tests look good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024
@msheppar
Copy link

The JBS ticket title should be changed to reflect the changes made

@frkator
Copy link
Member Author

frkator commented Dec 11, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@frkator
Your change (at version 4cf5712) is now ready to be sponsored by a Committer.

@JornVernee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

Going to push as commit cf0e1aa.
Since your change was applied there have been 82 commits pushed to the master branch:

  • 2c4567a: 8342651: Refactor array constant to use an array of jbyte
  • 72c6daf: 8346007: Incorrect copyright header in UModLNodeIdealizationTests.java
  • cc47918: 8345040: Clean up unused variables and code in generate_native_wrapper
  • c34b87c: 8345659: Fix broken alignment after ReservedSpace splitting in GC code
  • e294899: 8345647: Fix recent NULL usage backsliding in Shenandoah
  • d381d58: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes
  • 45c914c: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • a21d21f: 8345609: [C1] LIR Operations with one input should be implemented as LIR_Op1
  • 2382a2d: 8345661: Simplify page size alignment in code heap reservation
  • 076bfa6: 8345656: Move os alignment functions out of ReservedSpace
  • ... and 72 more: https://git.openjdk.org/jdk/compare/ef8da28487f918c38fab3096eaeed572d5ea5b90...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2024
@openjdk openjdk bot closed this Dec 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2024
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@JornVernee @frkator Pushed as commit cf0e1aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@frkator frkator deleted the isipka-JDK-8345335-add-excluded-jdk_foreign-tests-to-ATR-job branch December 11, 2024 16:41
@frkator frkator changed the title 8345335: Add excluded jdk_foreign tests to manual group 8345335: Add excluded jdk_foreign tests to tier4 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants