Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343890: SEGV crash in RunTimeClassInfo::klass #22583

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented Dec 5, 2024

Hi all,

This pull request contains a backport of commit bf0debc0 from the openjdk/jdk repository.

The commit being backported was authored by Matias Saavedra Silva on 5 Dec 2024 and was reviewed by Ioi Lam and Calvin Cheung.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343890: SEGV crash in RunTimeClassInfo::klass (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22583/head:pull/22583
$ git checkout pull/22583

Update a local copy of the PR:
$ git checkout pull/22583
$ git pull https://git.openjdk.org/jdk.git pull/22583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22583

View PR using the GUI difftool:
$ git pr show -t 22583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22583.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2024

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343890: SEGV crash in RunTimeClassInfo::klass

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport bf0debc023a42ccdf2f589039e4d98e11424b4dd 8343890: SEGV crash in RunTimeClassInfo::klass Dec 5, 2024
@openjdk
Copy link

openjdk bot commented Dec 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 5, 2024
@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 5, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2024

Webrevs

@matias9927
Copy link
Contributor Author

/clean

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@matias9927 The /clean pull request command is not enabled for this repository

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me a clean backport.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2024
@matias9927
Copy link
Contributor Author

Thanks for the review @calvinccheung! This is a clean backport so it only needs one review.
/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

Going to push as commit 3aa07db.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2024
@openjdk openjdk bot closed this Dec 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2024
@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@matias9927 Pushed as commit 3aa07db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants