Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8260506: VersionHelper cleanup #2259

Closed
wants to merge 1 commit into from
Closed

8260506: VersionHelper cleanup #2259

wants to merge 1 commit into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Jan 27, 2021 •
edited by openjdk bot

Some small modernizations and cleanups that ultimately help startup of apps using JNDI/InitialContext

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2259/head:pull/2259
$ git checkout pull/2259

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2021
@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 27, 2021 •
edited

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260506: VersionHelper cleanup

Reviewed-by: alanb, dfuchs, aefimov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 684c855: 8260524: validate-source fails on test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java
  • 311a0a9: 8259808: Add JFR event to detect GC locker stall
  • f353fcf: 8258894: C2: Forbid GCM to move stores into loops
  • ac276bb: 8257074: Update the ByteBuffers micro benchmark
  • 7ed591c: 8260314: Replace border="1" on tables with CSS
  • e696baa: 8260448: Simplify ManagementFactory$PlatformMBeanFinder
  • b3c8a52: 8259050: Error recovery in lexer could be improved
  • bf15c70: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
  • 3e4194c: 8260022: [ppc] os::print_function_and_library_name shall resolve function descriptors transparently
  • fa40a96: 8253420: Refactor HeapRegionManager::find_highest_free
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/fd00ed747a92454bb993580a05cb33c55a83eb16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2021
dfuch
dfuch approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I have satisfied myself that c couldn't be a primitive type if we reach here.
Please make sure to run tier2 for this one too.

@AlekseiEfimov
Copy link
Member

The changes looks good to me.

@cl4es
Copy link
Member Author

cl4es commented Jan 28, 2021

@AlanBateman @dfuch @AlekseiEfimov - thanks for reviewing!

/integrate

@openjdk openjdk bot closed this Jan 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@cl4es Since your change was applied there have been 35 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit ecde52e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseiEfimov AlekseiEfimov AlekseiEfimov approved these changes

@AlanBateman AlanBateman AlanBateman approved these changes

@dfuch dfuch dfuch approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
4 participants
@cl4es @AlekseiEfimov @AlanBateman @dfuch