-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout #22592
Conversation
…led: Warning found in stdout
👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into |
@mpdonova This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 97 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
Going to push as commit 153dc6d.
Your commit was automatically rebased without conflicts. |
I was unable to recreate the error but it is probably the same root cause as JDK-8337951 (#20728).
I updated the gencert command to explicitly set the start date to ensure the certificate is valid.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22592/head:pull/22592
$ git checkout pull/22592
Update a local copy of the PR:
$ git checkout pull/22592
$ git pull https://git.openjdk.org/jdk.git pull/22592/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22592
View PR using the GUI difftool:
$ git pr show -t 22592
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22592.diff
Using Webrev
Link to Webrev Comment