Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345629: Remove expired flags in JDK 25 #22593

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 6, 2024

All flags that expire in JDK 25 are removed from the special_jvm_flags table.

The Java command manpage is updated so that flags removed in the previous release are deleted from the "Removed flags" section and a link added to the previous release manpage. Any documented obsolete flags are moved to the "Removed section" from the "Obsoleted" section.

Testing: tiers 1-3 sanity

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345629: Remove expired flags in JDK 25 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22593/head:pull/22593
$ git checkout pull/22593

Update a local copy of the PR:
$ git checkout pull/22593
$ git pull https://git.openjdk.org/jdk.git pull/22593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22593

View PR using the GUI difftool:
$ git pr show -t 22593

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22593.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345629: Remove expired flags in JDK 25

Reviewed-by: kvn, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 470701f: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless
  • 573bcb6: 8345664: Use simple parameter type names in @link and @see tags
  • 4966419: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714
  • 0e2a285: 8344833: CTW: Make failing on zero classes optional
  • f6021a9: 8344668: Unnecessary array allocations and copying in TextLine
  • 874d68a: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8
  • d9a2213: 8345299: C2: some nodes can still have incorrect control after do_range_check()
  • 2286fae: 8345159: RISCV: Fix -Wzero-as-null-pointer-constant warning in emit_static_call_stub
  • 8403285: 8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield
  • aa38284: 8345435: Eliminate tier1_compiler_not_xcomp group

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2024
@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 6, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2024

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I assume link to JDK 24 docs will be populated after JDK 24 release. Right?
https://docs.oracle.com/en/java/javase/24/docs/specs/man/java.html

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2024
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

: Enables strict class-file format checks that enforce close conformance to
the class-file format specification. Developers should use this flag when
developing new code. Stricter checks may become the default in future
releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so this is what this option meant.

@dholmes-ora
Copy link
Member Author

I assume link to JDK 24 docs will be populated after JDK 24 release. Right?

Right.

Thanks for the reviews @vnkozlov and @coleenp !

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2024

Going to push as commit 83ea013.
Since your change was applied there have been 12 commits pushed to the master branch:

  • c517ffb: 8339910: RISC-V: crc32 intrinsic with carry-less multiplication
  • e0d6398: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler
  • 470701f: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless
  • 573bcb6: 8345664: Use simple parameter type names in @link and @see tags
  • 4966419: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714
  • 0e2a285: 8344833: CTW: Make failing on zero classes optional
  • f6021a9: 8344668: Unnecessary array allocations and copying in TextLine
  • 874d68a: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8
  • d9a2213: 8345299: C2: some nodes can still have incorrect control after do_range_check()
  • 2286fae: 8345159: RISCV: Fix -Wzero-as-null-pointer-constant warning in emit_static_call_stub
  • ... and 2 more: https://git.openjdk.org/jdk/compare/9284602ecbbed94af38f90fd080684cdb33d5f31...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2024
@openjdk openjdk bot closed this Dec 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2024
@openjdk
Copy link

openjdk bot commented Dec 8, 2024

@dholmes-ora Pushed as commit 83ea013.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8345629-expired branch December 8, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants