-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345629: Remove expired flags in JDK 25 #22593
Conversation
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I assume link to JDK 24 docs will be populated after JDK 24 release. Right?
https://docs.oracle.com/en/java/javase/24/docs/specs/man/java.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
: Enables strict class-file format checks that enforce close conformance to | ||
the class-file format specification. Developers should use this flag when | ||
developing new code. Stricter checks may become the default in future | ||
releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh so this is what this option meant.
Going to push as commit 83ea013.
Your commit was automatically rebased without conflicts. |
@dholmes-ora Pushed as commit 83ea013. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
All flags that expire in JDK 25 are removed from the special_jvm_flags table.
The Java command manpage is updated so that flags removed in the previous release are deleted from the "Removed flags" section and a link added to the previous release manpage. Any documented obsolete flags are moved to the "Removed section" from the "Obsoleted" section.
Testing: tiers 1-3 sanity
Thanks
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22593/head:pull/22593
$ git checkout pull/22593
Update a local copy of the PR:
$ git checkout pull/22593
$ git pull https://git.openjdk.org/jdk.git pull/22593/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22593
View PR using the GUI difftool:
$ git pr show -t 22593
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22593.diff
Using Webrev
Link to Webrev Comment