8344556: [Graal] compiler/intrinsics/bmi/* fail when AOTCache cannot be loaded

[iklam]

See JBS issue for detailed evaluation.

In summary -- when -XX:+UseJVMCICompiler is used, one of -int or -Xcomp will print out the [cds][error] message. The work around is to disable the CDS log for both cases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344556: [Graal] compiler/intrinsics/bmi/* fail when AOTCache cannot be loaded (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22596/head:pull/22596
$ git checkout pull/22596

Update a local copy of the PR:
$ git checkout pull/22596
$ git pull https://git.openjdk.org/jdk.git pull/22596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22596

View PR using the GUI difftool:
$ git pr show -t 22596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22596.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6f2d9ef7)

[vnkozlov]

I agree with @dougxc suggestion in bug's comment:
"these tests should not be run with -XX:+AOTClassLinking when JVMCI is enabled"

Is it possible to add such condition to tests @require ?

[iklam]

I agree with @dougxc suggestion in bug's comment: "these tests should not be run with -XX:+AOTClassLinking when JVMCI is enabled"

Is it possible to add such condition to tests @require ?

For test coverage, I think we should test it for this flag combination as well. We just need to fix the test so that it doesn't care about unrelated error messages.

[iklam]

There's a better fix by adding --add-modules=jdk.internal.vm.ci when running the tests under this configuration. Please see more info in JDK-8344556.

$ env JVMCI_VERSION_CHECK=ignore make test \
     JTREG_AOT_JDK=true \
     TEST_OPTS_VM_OPTIONS="--add-modules=jdk.internal.vm.ci -XX:+AOTClassLinking -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler" \
     JTREG_OPTIONS="-e:JVMCI_VERSION_CHECK=ignore" \
     TEST=open/test/hotspot/jtreg/compiler/intrinsics/bmi/TestLzcntL.java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:open/test/hotspot/jtreg/compiler/intrinsics/bmi/TestLzcntL.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

Closing this PR.