Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334581: Remove no-arg constructor BasicSliderUI() #22598

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Dec 6, 2024

The no-arg constructor BasicSliderUI() was added accidentally. It should be removed.

JDK-8334580 deprecates the BasicSliderUI() constructor, and this follow-up is to remove the constructor.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8345648 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8334581: Remove no-arg constructor BasicSliderUI() (Bug - P3)
  • JDK-8345648: Remove no-arg constructor BasicSliderUI() (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22598/head:pull/22598
$ git checkout pull/22598

Update a local copy of the PR:
$ git checkout pull/22598
$ git pull https://git.openjdk.org/jdk.git pull/22598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22598

View PR using the GUI difftool:
$ git pr show -t 22598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22598.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334581: Remove no-arg constructor BasicSliderUI()

Reviewed-by: abhiscxk, aivanov, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • cc628a1: 8345287: C2: live in computation is broken
  • 480b508: 8345156: C2: Add bailouts next to a few asserts
  • b120404: 8345793: Update copyright year to 2024 for the build system in files where it was missed
  • 7aa0cbc: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
  • 35c0053: 8345405: Add JMH showing the regression in 8341649
  • 166c127: 8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302
  • e821d59: 8345589: Simplify Windows definition of strtok_r
  • 153dc6d: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • d7ef3ac: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
  • 830173f: 8344068: Windows x86-64: Out of CodeBuffer space when generating final stubs
  • ... and 38 more: https://git.openjdk.org/jdk/compare/b42d79eb6a6d497dc63718c2854609bebca4498c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 6, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2024
@kumarabhi006
Copy link
Contributor

Do we need a CSR for removal ?

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels Dec 6, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Dec 9, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

Going to push as commit c40140e.
Since your change was applied there have been 73 commits pushed to the master branch:

  • 8de0622: 8345767: javax/swing/JSplitPane/4164779/JSplitPaneKeyboardNavigationTest.java fails in ubuntu22.04
  • abcd23f: 8334756: javac crashed on call to non-existent generic method with explicit annotated type arg
  • 2ddaa46: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
  • c631719: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor
  • 29d648c: 8341781: Improve Min/Max node identities
  • 4c39e9f: 8344924: Default CA certificates loaded despite request to use custom keystore
  • 0f03554: 8342469: Improve API documentation for java.lang.classfile.instruction
  • 9bd70ec: 8345888: Broken links in the JDK 24 JavaDoc API documentation, build 27
  • 1def2d8: 8345700: tier{1,2,3}_compiler don't cover all compiler tests
  • d6b5264: 8345746: Remove :resourcehogs/compiler from :hotspot_slow_compiler
  • ... and 63 more: https://git.openjdk.org/jdk/compare/b42d79eb6a6d497dc63718c2854609bebca4498c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2024
@openjdk openjdk bot closed this Dec 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@prsadhuk Pushed as commit c40140e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8334581 branch December 11, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants