JDK-8260335: [macos] Running app using relative path causes problems #2260
Conversation
|
|
|
@andyherrick To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/core-libs |
|
/label core-libs |
|
@andyherrick |
Webrevs
|
There was a problem hiding this comment.
Aside of small change requested by @alexeysemenyukoracle looks fine.
|
@andyherrick This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Reviewed-by: dcubed
Reviewed-by: shade, rriggs
Reviewed-by: rkennke, shade
…ompatibility/Compatibility.java" fails Reviewed-by: rhalade
Reviewed-by: aivanov, pbansal
Reviewed-by: rkennke, shade
Reviewed-by: neliasso, chagedorn, thartmann, phh
…CLOCK_MONOTONIC Reviewed-by: ihse, erikj, gziemski, hseigel
…ption when initialCapacity is negative Reviewed-by: psadhukhan, kizune
Co-authored-by: Dominik Röttsches <drott@google.com> Reviewed-by: jiangli, valeriep
… code Reviewed-by: zgu, rkennke
Reviewed-by: shade, iklam, dholmes
Reviewed-by: coleenp, shade
…_empty() Reviewed-by: tschatzl
Reviewed-by: sjohanss, kbarrett
… of in_bb(fin2) Reviewed-by: shade
Reviewed-by: jlahoda
…incorrect Reviewed-by: jlahoda, tvaleev
… modifier Reviewed-by: sspitsyn, coleenp
Reviewed-by: rhalade, jnimeh
…nfigs Reviewed-by: vlivanov
Reviewed-by: rriggs, naoto, lancea, dfuchs
Reviewed-by: dcubed, gziemski, eosterlund, cjplummer, sspitsyn
8260629: Remove explicit instantiation of Hashtable with oop value Reviewed-by: pliden, tschatzl, coleenp
Reviewed-by: serb, psadhukhan
…figs Reviewed-by: iignatyev
Reviewed-by: vlivanov, kvn
Reviewed-by: tschatzl, kbarrett
Reviewed-by: shade, chagedorn, kvn
…s module without "requires java.base" Reviewed-by: attila, alanb
…cans Reviewed-by: zgu, rkennke
Reviewed-by: roland, thartmann
…ompilation issues Reviewed-by: alanb
Reviewed-by: tbell, iris, mikael, ihse
Reviewed-by: vlivanov, thartmann, chagedorn
Reviewed-by: lfoltan, coleenp
|
/integrate |
openjdk
bot
added
integrated
|
@andyherrick Since your change was applied there have been 64 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c1dea39. |
Fixing FileUtils.dirname() to skip over "/.".
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2260/head:pull/2260$ git checkout pull/2260