Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8260335: [macos] Running app using relative path causes problems #2260

Closed
wants to merge 86 commits into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Jan 27, 2021

Fixing FileUtils.dirname() to skip over "/.".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260335: [macos] Running app using relative path causes problems

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2260/head:pull/2260
$ git checkout pull/2260

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 27, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@andyherrick To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing
@andyherrick andyherrick marked this pull request as ready for review Jan 27, 2021
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Jan 27, 2021

/core-libs

@openjdk openjdk bot added the rfr label Jan 27, 2021
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Jan 28, 2021

/label core-libs

@openjdk openjdk bot added the core-libs label Jan 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@andyherrick
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 28, 2021

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Aside of small change requested by @alexeysemenyukoracle looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260335: [macos] Running app using relative path causes problems

Reviewed-by: almatvee, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
  • d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
  • 0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
  • defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
  • a421bfa: 8259839: SystemDictionary exports too much implementation
  • 189b65b: 8260264: Move common os_ inline methods to a common posix source file
  • 288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
  • ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • fe407cf: 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 474dba2: 8257086: Clarify differences between {Float, Double}.equals and ==
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/181d63ffcee7a2f03ed9b8278b5ffface71a494f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 2, 2021
jerboaa and others added 15 commits Jan 26, 2021
Reviewed-by: shade, rriggs
…ompatibility/Compatibility.java" fails

Reviewed-by: rhalade
Reviewed-by: neliasso, chagedorn, thartmann, phh
…CLOCK_MONOTONIC

Reviewed-by: ihse, erikj, gziemski, hseigel
…ption when initialCapacity is negative

Reviewed-by: psadhukhan, kizune
Co-authored-by: Dominik Röttsches <drott@google.com>
Reviewed-by: jiangli, valeriep
Vladimir Kozlov and others added 23 commits Jan 29, 2021
Reviewed-by: rriggs, naoto, lancea, dfuchs
Reviewed-by: dcubed, gziemski, eosterlund, cjplummer, sspitsyn
8260629: Remove explicit instantiation of Hashtable with oop value

Reviewed-by: pliden, tschatzl, coleenp
Reviewed-by: serb, psadhukhan
…s module without "requires java.base"

Reviewed-by: attila, alanb
Reviewed-by: roland, thartmann
Reviewed-by: tbell, iris, mikael, ihse
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@andyherrick Since your change was applied there have been 64 commits pushed to the master branch:

  • f7a6cff: 8261149: Initial nroff manpage update for JDK 17
  • be772ff: 8261023: Document why memory pretouch must be a store
  • 83357b1: 8261030: Avoid loading GenerateJLIClassesHelper at runtime
  • 992b500: 8261036: Reduce classes loaded by CleanerFactory initialization
  • e8ad8b3: 8259956: jdk.jfr.internal.ChunkInputStream#available should return the sum of remaining available bytes
  • 06b33a0: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)
  • 60f440d: 6436374: Graphics.setColor(null) is not documented
  • 82028e7: 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp
  • 9b7a8f1: Merge
  • 1a7040e: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)
  • ... and 54 more: https://git.openjdk.java.net/jdk/compare/181d63ffcee7a2f03ed9b8278b5ffface71a494f...master

Your commit was automatically rebased without conflicts.

Pushed as commit c1dea39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the andyherrick:JDK-8260335 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment