8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827

[Hamlin-Li]

Hi,
Can you help to review this simple fix?
Thanks!

Previously in JDK-8343827, AlignVector was enabled conditionally, but the code was put in common path (shared with non-C2 code), but in fact this flag is only for C2.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827 (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Ludovic Henry (@luhenry - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22605/head:pull/22605
$ git checkout pull/22605

Update a local copy of the PR:
$ git checkout pull/22605
$ git pull https://git.openjdk.org/jdk.git pull/22605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22605

View PR using the GUI difftool:
$ git pr show -t 22605

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22605.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• a6277bb: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
• 165fd84: 8342987: Update --release 24 symbol information for JDK 24 build 27
• 06c44dd: 8345465: Fix performance regression on x64 after JDK-8345120
• 2979806: 8345795: Update copyright year to 2024 for hotspot in files where it was missed
• 7e73c43: 8345217: Parallel: Refactor PSParallelCompact::next_src_region
• 7d3a404: 8339019: Obsolete the UseLinuxPosixThreadCPUClocks flag
• a606836: 8345744: Use C++ LINK_TYPE with SetupBuildLauncher in StaticLibs.gmk
• fe0173d: 8345803: Update copyright year to 2024 for security in files where it was missed
• 2207749: 8344629: SSLSocketNoServerHelloClientShutdown test timeout
• 0b9e749: 8345390: [ubsan] systemDictionaryShared.cpp:964: member call on null pointer
• ... and 46 more: https://git.openjdk.org/jdk/compare/456c71d1ff64d31445b68d792fdaa9887f3499da...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f4e86ecf)

[RealFYang]

Thanks. Seems this should be fixed for jdk24 as well.

[Hamlin-Li]

Thanks. Seems this should be fixed for jdk24 as well.

Yes, I think so. I just found this issue when I work on another task.
I think this pr will not get into 24 automatically, maybe a backport is needed? I'll backport it later.

[Hamlin-Li]

Thanks for your reviews!

/integrate

[openjdk]

Going to push as commit a24b08f.
Since your change was applied there have been 57 commits pushed to the master branch:

• 25d9deb: 8335367: [s390] Add support for load immediate on condition instructions.
• a6277bb: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
• 165fd84: 8342987: Update --release 24 symbol information for JDK 24 build 27
• 06c44dd: 8345465: Fix performance regression on x64 after JDK-8345120
• 2979806: 8345795: Update copyright year to 2024 for hotspot in files where it was missed
• 7e73c43: 8345217: Parallel: Refactor PSParallelCompact::next_src_region
• 7d3a404: 8339019: Obsolete the UseLinuxPosixThreadCPUClocks flag
• a606836: 8345744: Use C++ LINK_TYPE with SetupBuildLauncher in StaticLibs.gmk
• fe0173d: 8345803: Update copyright year to 2024 for security in files where it was missed
• 2207749: 8344629: SSLSocketNoServerHelloClientShutdown test timeout
• ... and 47 more: https://git.openjdk.org/jdk/compare/456c71d1ff64d31445b68d792fdaa9887f3499da...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit a24b08f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[RealFYang]

Thanks. Seems this should be fixed for jdk24 as well.

Yes, I think so. I just found this issue when I work on another task. I think this pr will not get into 24 automatically, maybe a backport is needed? I'll backport it later.

Yes, I think we should do a backport. And the repo is there: https://github.com/openjdk/jdk24u

[Hamlin-Li]

/backport :jdk24

[openjdk]

@Hamlin-Li the backport was successfully created on the branch backport-Hamlin-Li-a24b08fc-jdk24 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk24, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit a24b08fc from the openjdk/jdk repository.

The commit being backported was authored by Hamlin Li on 10 Dec 2024 and was reviewed by Fei Yang and Ludovic Henry.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-Hamlin-Li-a24b08fc-jdk24:backport-Hamlin-Li-a24b08fc-jdk24
$ git checkout backport-Hamlin-Li-a24b08fc-jdk24
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-Hamlin-Li-a24b08fc-jdk24

⚠️ @Hamlin-Li You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.