Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302 #22615

Closed

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Dec 6, 2024

In JDK-8345302 I updated the default JAVA_FLAGS_BIG to -Xmx2048M in configure. In RunTestPrebuiltSpec.gmk, there is a copy of this value that also needs to be updated as it should mimic a typical configuration.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22615/head:pull/22615
$ git checkout pull/22615

Update a local copy of the PR:
$ git checkout pull/22615
$ git pull https://git.openjdk.org/jdk.git pull/22615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22615

View PR using the GUI difftool:
$ git pr show -t 22615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22615.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2024

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • e821d59: 8345589: Simplify Windows definition of strtok_r
  • 153dc6d: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • d7ef3ac: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
  • 830173f: 8344068: Windows x86-64: Out of CodeBuffer space when generating final stubs
  • 69e664d: 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function
  • 842b363: 8345698: Remove tier1_compiler_not_xcomp from github actions
  • 458979d: 8344611: Add missing classpath exception
  • 83ea013: 8345629: Remove expired flags in JDK 25
  • c517ffb: 8339910: RISC-V: crc32 intrinsic with carry-less multiplication
  • e0d6398: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler
  • ... and 11 more: https://git.openjdk.org/jdk/compare/41c8971cbcc1d281ffae907c952637ebff945ebb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8345726 8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302 Dec 6, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2024
@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 6, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2024

Webrevs

@magicus
Copy link
Member

magicus commented Dec 9, 2024

Thanks for fixing!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2024
@erikj79
Copy link
Member Author

erikj79 commented Dec 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2024

Going to push as commit 166c127.
Since your change was applied there have been 21 commits pushed to the master branch:

  • e821d59: 8345589: Simplify Windows definition of strtok_r
  • 153dc6d: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • d7ef3ac: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
  • 830173f: 8344068: Windows x86-64: Out of CodeBuffer space when generating final stubs
  • 69e664d: 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function
  • 842b363: 8345698: Remove tier1_compiler_not_xcomp from github actions
  • 458979d: 8344611: Add missing classpath exception
  • 83ea013: 8345629: Remove expired flags in JDK 25
  • c517ffb: 8339910: RISC-V: crc32 intrinsic with carry-less multiplication
  • e0d6398: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler
  • ... and 11 more: https://git.openjdk.org/jdk/compare/41c8971cbcc1d281ffae907c952637ebff945ebb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 9, 2024
@openjdk openjdk bot closed this Dec 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2024
@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@erikj79 Pushed as commit 166c127.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants