-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302 #22615
8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302 #22615
Conversation
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks for fixing! |
/integrate |
Going to push as commit 166c127.
Your commit was automatically rebased without conflicts. |
In JDK-8345302 I updated the default JAVA_FLAGS_BIG to -Xmx2048M in configure. In RunTestPrebuiltSpec.gmk, there is a copy of this value that also needs to be updated as it should mimic a typical configuration.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22615/head:pull/22615
$ git checkout pull/22615
Update a local copy of the PR:
$ git checkout pull/22615
$ git pull https://git.openjdk.org/jdk.git pull/22615/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22615
View PR using the GUI difftool:
$ git pr show -t 22615
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22615.diff
Using Webrev
Link to Webrev Comment