8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual #22620

plummercj · 2024-12-06T22:28:29Z

This test fails after JDK-8338713 when using JTREG_TEST_THREAD_FACTORY=Virtual. The test uses JVMTI StopThread on a thread expecting it to be mounted. Before JDK-8338713 it would be mounted because it was blocked on a syncrhonized, which resulted in the thread being pinned. After JDK-8338713 this is no longer the case and the virtual thread has unmounted. This causes JVMTI StopThread to fail with JVMTI_ERROR_OPAQUE_FRAME because it only supports mounted virtual threads.

Fixed by using the VThreadPinner class to make sure the virtual threads remains pinned, and therefore mounted.

Testing:

Ran jdb tests locally in both virtual thread mode and platform thread mode.
tier1
tier2 svc
tier5 svc

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual (Bug - P4)

Reviewers

Serguei Spitsyn (@sspitsyn - Reviewer)
David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22620/head:pull/22620
$ git checkout pull/22620

Update a local copy of the PR:
$ git checkout pull/22620
$ git pull https://git.openjdk.org/jdk.git pull/22620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22620

View PR using the GUI difftool:
$ git pr show -t 22620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22620.diff

Using Webrev

Link to Webrev Comment

…hread is called.

bridgekeeper · 2024-12-06T22:29:29Z

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-12-06T22:29:37Z

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual

Reviewed-by: sspitsyn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 142 new commits pushed to the master branch:

dc71e8c: 8342995: Enhance Attach API to support arbitrary length arguments - Linux
4f44cf6: 8341481: [perf] vframeStreamCommon constructor may be optimized
390b205: 8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor
03821d9: 8346195: Fix static initialization problem in GDIHashtable
a5503fb: 8346432: java.lang.foreign.Linker comment typo
fbd76ca: 8337016: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM
baeb3d9: 8346304: SA doesn't need a copy of getModifierFlags
99af595: 8345942: Separate source output from class output when building microbenchmarks
8a64595: 8346282: [JVMCI] Add failure reason support to UnresolvedJava/Type/Method/Field
725079b: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException
... and 132 more: https://git.openjdk.org/jdk/compare/470701f0bb269834cc0e1cb40f7d34e92226454b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-12-06T22:30:27Z

@plummercj The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-12-06T22:32:46Z

Webrevs

01: Full - Incremental (d801499f)
00: Full (47ccd8db)

AlanBateman · 2024-12-07T07:33:07Z

test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001a.java

+        }
+    }
+
+    public void run1() {


It might be a bit clear to rename run1 to runPinned or something better to avoid run + run1.

It also needs to support test runs with platforms threads. See how run() checks if it is running in virtual thread mode or not. Either way it calls run(), but in the virtual thread case it does so using VThreadPinner.

AlanBateman · 2024-12-07T07:33:38Z

test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java

@@ -137,6 +137,9 @@ private String[] makeJdbCmdLine (String classToExecute) {
                /* Some tests need more carrier threads than the default provided. */
                args.add("-R-Djdk.virtualThreadScheduler.parallelism=15");
            }
+            /* Some jdb tests need java.library.path setup for native libraries. */
+            String libpath = System.getProperty("java.library.path");
+            args.add("-R-Djava.library.path=" + libpath);


Good, I wasn't sure how this would inherit.

This seems like an unrelated change. ???

jdk.test.lib.thread.VThreadPinner has a native library that must be loaded.

Ah I see. Thanks

sspitsyn

The fix looks good modulo potential renaming of the run1() method.

plummercj · 2024-12-09T21:21:10Z

The fix looks good modulo potential renaming of the run1() method.

I think you and @AlanBateman didn't quite understand what I meant by:

It also needs to support test runs with platforms threads. See how run() checks if it is running in virtual thread mode or not. Either way it calls run(), but in the virtual thread case it does so using VThreadPinner.

The run1() method is called regardless of whether or not we are using vthreads and VThreadPinner, so I don't think runPinned() is a good name for it.

sspitsyn · 2024-12-09T21:44:42Z

I think you and @AlanBateman didn't quite understand what I meant by:
. . .
The run1() method is called regardless of whether or not we are using vthreads and VThreadPinner, so I don't think runPinned() is a good name for it.

In fact, I understand it. I was thinking if renaming to something like runPlatformOrPinnedVirtual() would work. But there is no pressure from me on this as the method name will become kind of lengthy. :)

plummercj · 2024-12-09T22:03:43Z

I think you and @AlanBateman didn't quite understand what I meant by:
. . .
The run1() method is called regardless of whether or not we are using vthreads and VThreadPinner, so I don't think runPinned() is a good name for it.

In fact, I understand it. I was thinking if renaming to something like runPlatformOrPinnedVirtual() would work. But there is no pressure from me on this as the method name will become kind of lengthy. :)

It is wordy. Maybe runShared or runCommon, although I don't think either adds much value.

sspitsyn · 2024-12-11T11:24:57Z

It is wordy. Maybe runShared or runCommon, although I don't think either adds much value.

Or it can be just something like doit() or test(). :)

plummercj · 2024-12-16T17:25:02Z

Looking for one more review. Thanks!

dholmes-ora

Hitting approve, but the launcher change seems unrelated to the issue at hand.

dholmes-ora · 2024-12-17T01:59:52Z

test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java

@@ -137,6 +137,9 @@ private String[] makeJdbCmdLine (String classToExecute) {
                /* Some tests need more carrier threads than the default provided. */
                args.add("-R-Djdk.virtualThreadScheduler.parallelism=15");
            }
+            /* Some jdb tests need java.library.path setup for native libraries. */
+            String libpath = System.getProperty("java.library.path");
+            args.add("-R-Djava.library.path=" + libpath);


This seems like an unrelated change. ???

plummercj · 2024-12-17T19:04:13Z

Thanks David and Serguei!

/integrate

openjdk · 2024-12-17T19:06:09Z

Going to push as commit 414eb6b.
Since your change was applied there have been 142 commits pushed to the master branch:

dc71e8c: 8342995: Enhance Attach API to support arbitrary length arguments - Linux
4f44cf6: 8341481: [perf] vframeStreamCommon constructor may be optimized
390b205: 8346048: test/lib/containers/docker/DockerRunOptions.java uses addJavaOpts() from ctor
03821d9: 8346195: Fix static initialization problem in GDIHashtable
a5503fb: 8346432: java.lang.foreign.Linker comment typo
fbd76ca: 8337016: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM
baeb3d9: 8346304: SA doesn't need a copy of getModifierFlags
99af595: 8345942: Separate source output from class output when building microbenchmarks
8a64595: 8346282: [JVMCI] Add failure reason support to UnresolvedJava/Type/Method/Field
725079b: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException
... and 132 more: https://git.openjdk.org/jdk/compare/470701f0bb269834cc0e1cb40f7d34e92226454b...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-12-17T19:06:20Z

@plummercj Pushed as commit 414eb6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Use VThreadPinner to make sure virtual threads are mounted when StopT…

47ccd8d

…hread is called.

openjdk bot changed the title ~~8338714~~ 8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual. Dec 6, 2024

openjdk bot added the rfr Pull request is ready for review label Dec 6, 2024

openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 6, 2024

AlanBateman reviewed Dec 7, 2024

View reviewed changes

sspitsyn reviewed Dec 9, 2024

View reviewed changes

Rename run1() to test()

d801499

sspitsyn approved these changes Dec 11, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024

dholmes-ora approved these changes Dec 17, 2024

View reviewed changes

plummercj changed the title ~~8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual.~~ 8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual Dec 17, 2024

openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Dec 17, 2024

openjdk bot added the integrated Pull request has been integrated label Dec 17, 2024

openjdk bot closed this Dec 17, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual #22620

8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual #22620

plummercj commented Dec 6, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 6, 2024

openjdk bot commented Dec 6, 2024 •

edited

Loading

openjdk bot commented Dec 6, 2024

mlbridge bot commented Dec 6, 2024 •

edited

Loading

AlanBateman Dec 7, 2024 •

edited

Loading

plummercj Dec 7, 2024

AlanBateman Dec 7, 2024 •

edited

Loading

dholmes-ora Dec 17, 2024

plummercj Dec 17, 2024

dholmes-ora Dec 17, 2024

sspitsyn left a comment

plummercj commented Dec 9, 2024 •

edited

Loading

sspitsyn commented Dec 9, 2024 •

edited

Loading

plummercj commented Dec 9, 2024

sspitsyn commented Dec 11, 2024 •

edited

Loading

plummercj commented Dec 16, 2024

dholmes-ora left a comment

dholmes-ora Dec 17, 2024

plummercj commented Dec 17, 2024

openjdk bot commented Dec 17, 2024

openjdk bot commented Dec 17, 2024

8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual #22620

8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual #22620

Conversation

plummercj commented Dec 6, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Dec 6, 2024

openjdk bot commented Dec 6, 2024 • edited Loading

openjdk bot commented Dec 6, 2024

mlbridge bot commented Dec 6, 2024 • edited Loading

Webrevs

AlanBateman Dec 7, 2024 • edited Loading

Choose a reason for hiding this comment

plummercj Dec 7, 2024

Choose a reason for hiding this comment

AlanBateman Dec 7, 2024 • edited Loading

Choose a reason for hiding this comment

dholmes-ora Dec 17, 2024

Choose a reason for hiding this comment

plummercj Dec 17, 2024

Choose a reason for hiding this comment

dholmes-ora Dec 17, 2024

Choose a reason for hiding this comment

sspitsyn left a comment

Choose a reason for hiding this comment

plummercj commented Dec 9, 2024 • edited Loading

sspitsyn commented Dec 9, 2024 • edited Loading

plummercj commented Dec 9, 2024

sspitsyn commented Dec 11, 2024 • edited Loading

plummercj commented Dec 16, 2024

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Dec 17, 2024

Choose a reason for hiding this comment

plummercj commented Dec 17, 2024

openjdk bot commented Dec 17, 2024

openjdk bot commented Dec 17, 2024

plummercj commented Dec 6, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Dec 6, 2024 •

edited

Loading

mlbridge bot commented Dec 6, 2024 •

edited

Loading

AlanBateman Dec 7, 2024 •

edited

Loading

AlanBateman Dec 7, 2024 •

edited

Loading

plummercj commented Dec 9, 2024 •

edited

Loading

sspitsyn commented Dec 9, 2024 •

edited

Loading

sspitsyn commented Dec 11, 2024 •

edited

Loading