8345693: Update JCov for class file version 69 #22625

shurymury · 2024-12-07T02:21:22Z

Use a CI promoted build.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8345693: Update JCov for class file version 69 (Task - P2)

Reviewers

Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22625/head:pull/22625
$ git checkout pull/22625

Update a local copy of the PR:
$ git checkout pull/22625
$ git pull https://git.openjdk.org/jdk.git pull/22625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22625

View PR using the GUI difftool:
$ git pr show -t 22625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22625.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-12-07T02:22:11Z

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-12-07T02:22:32Z

@shurymury This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345693: Update JCov for class file version 69

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

cc628a1: 8345287: C2: live in computation is broken
480b508: 8345156: C2: Add bailouts next to a few asserts
b120404: 8345793: Update copyright year to 2024 for the build system in files where it was missed
7aa0cbc: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
35c0053: 8345405: Add JMH showing the regression in 8341649
166c127: 8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302
e821d59: 8345589: Simplify Windows definition of strtok_r
153dc6d: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
d7ef3ac: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
830173f: 8344068: Windows x86-64: Out of CodeBuffer space when generating final stubs
... and 7 more: https://git.openjdk.org/jdk/compare/573bcb61809cbd98ec52d159d0c8e030e4a8e3f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-12-07T02:23:08Z

@shurymury The following label will be automatically applied to this pull request:

build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-12-07T02:38:04Z

Webrevs

AlanBateman · 2024-12-07T13:49:34Z

make/conf/jib-profiles.js

+            build_number: "1",
+            file: "bundles/jcov-3.0+1.zip",
+            environment_name: "JCOV_HOME", 
+            configure_args: "--with-jcov=" + input.get("jcov", "home_path"),


I tried it, and it works for me, thank you! Note there's a space after "JCOV_HOME", that you might want to remove.

Actually, when I took a second look, I realize the configure_args argument is probably not needed, since it should be default. Can you check if it works without it?

magicus

Looks good. Please remove the trailing space. (We really should have jcheck verifying .js files as well...)

shurymury · 2024-12-09T15:23:27Z

/integrate

openjdk · 2024-12-09T15:23:36Z

@shurymury This pull request has not yet been marked as ready for integration.

magicus · 2024-12-09T15:58:18Z

make/conf/jib-profiles.js

+            build_number: "1",
+            file: "bundles/jcov-3.0+1.zip",
+            environment_name: "JCOV_HOME", 
+            configure_args: "--with-jcov=" + input.get("jcov", "home_path"),


Actually, when I took a second look, I realize the configure_args argument is probably not needed, since it should be default. Can you check if it works without it?

shurymury · 2024-12-09T18:09:33Z

Indeed, it works without the configure args. Removed. Thank you.

magicus

Perfect, thanks!

shurymury · 2024-12-09T19:43:30Z

/integrate

openjdk · 2024-12-09T19:43:58Z

Going to push as commit 48e22ba.
Since your change was applied there have been 17 commits pushed to the master branch:

cc628a1: 8345287: C2: live in computation is broken
480b508: 8345156: C2: Add bailouts next to a few asserts
b120404: 8345793: Update copyright year to 2024 for the build system in files where it was missed
7aa0cbc: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
35c0053: 8345405: Add JMH showing the regression in 8341649
166c127: 8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302
e821d59: 8345589: Simplify Windows definition of strtok_r
153dc6d: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
d7ef3ac: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE
830173f: 8344068: Windows x86-64: Out of CodeBuffer space when generating final stubs
... and 7 more: https://git.openjdk.org/jdk/compare/573bcb61809cbd98ec52d159d0c8e030e4a8e3f5...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-12-09T19:44:11Z

@shurymury Pushed as commit 48e22ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8345693: Update JCov for class file version 69

1fc7a81

openjdk bot added the build build-dev@openjdk.org label Dec 7, 2024

openjdk bot changed the title ~~JDK-8345693: Update JCov for class file version 69~~ 8345693: Update JCov for class file version 69 Dec 7, 2024

openjdk bot added the rfr Pull request is ready for review label Dec 7, 2024

AlanBateman reviewed Dec 7, 2024

View reviewed changes

magicus approved these changes Dec 9, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2024

removed a trailing space

4cd4ac1

openjdk bot removed the ready Pull request is ready to be integrated label Dec 9, 2024

magicus approved these changes Dec 9, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2024

magicus suggested changes Dec 9, 2024

View reviewed changes

openjdk bot removed the ready Pull request is ready to be integrated label Dec 9, 2024

removed an unneeded line

cd6d8ef

magicus approved these changes Dec 9, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2024

openjdk bot added the integrated Pull request has been integrated label Dec 9, 2024

openjdk bot closed this Dec 9, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2024

8345693: Update JCov for class file version 69 #22625

8345693: Update JCov for class file version 69 #22625

Uh oh!

Conversation

shurymury commented Dec 7, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Dec 7, 2024

Uh oh!

openjdk bot commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Dec 7, 2024

Uh oh!

mlbridge bot commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

AlanBateman Dec 7, 2024

Choose a reason for hiding this comment

Uh oh!

magicus Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

magicus left a comment

Choose a reason for hiding this comment

Uh oh!

shurymury commented Dec 9, 2024

Uh oh!

openjdk bot commented Dec 9, 2024

Uh oh!

magicus Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

shurymury commented Dec 9, 2024

Uh oh!

magicus left a comment

Choose a reason for hiding this comment

Uh oh!

shurymury commented Dec 9, 2024

Uh oh!

openjdk bot commented Dec 9, 2024

Uh oh!

openjdk bot commented Dec 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

shurymury commented Dec 7, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Dec 7, 2024 •

edited

Loading

mlbridge bot commented Dec 7, 2024 •

edited

Loading