8345876: Update nativeAddAtIndex comment to match the code

[saagarjha]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345876: Update nativeAddAtIndex comment to match the code (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer) Review applies to 62da15c0
• Alexander Zvegintsev (@azvegint - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer) Review applies to 62da15c0
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22627/head:pull/22627
$ git checkout pull/22627

Update a local copy of the PR:
$ git checkout pull/22627
$ git pull https://git.openjdk.org/jdk.git pull/22627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22627

View PR using the GUI difftool:
$ git pr show -t 22627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22627.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back saagarjha! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@saagarjha This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345876: Update nativeAddAtIndex comment to match the code

Reviewed-by: azvegint, aivanov, psadhukhan, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 64fad1c: 8345797: Update copyright year to 2024 for client-libs in files where it was missed
• ddf0461: 8345799: Update copyright year to 2024 for core-libs in files where it was missed
• cbab40b: 8345683: Remove special flags for files compiled for static libraries
• 08bdeed: 8345269: Fix -Wzero-as-null-pointer-constant warnings in ppc code
• e4a34e9: 8345616: Unnecessary Hashtable usage in javax.swing.text.html.parser.Element
• cce5808: 8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit
• cf0e1aa: 8345335: Add excluded jdk_foreign tests to manual group
• 2c4567a: 8342651: Refactor array constant to use an array of jbyte
• 72c6daf: 8346007: Incorrect copyright header in UModLNodeIdealizationTests.java
• cc47918: 8345040: Clean up unused variables and code in generate_native_wrapper
• ... and 10 more: https://git.openjdk.org/jdk/compare/f88c1c6ff86b8f29a71647e46136b6432bb67619...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prsadhuk, @azvegint, @azuev-java, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

⚠️ @saagarjha a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master e0d639878346946d0627a57b0eeb0cac8ca533fc
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk]

@saagarjha The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[prsadhuk]

No issue listed..I have added one

[prsadhuk]

/issue add JDK-8345876

[openjdk]

@prsadhuk Only the author (@saagarjha) is allowed to issue the /issue command.

[prsadhuk]

ALso you need to verify your OCA status

[saagarjha]

/issue add JDK-8345876

[openjdk]

@saagarjha The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[mlbridge]

Webrevs

• 01: Full - Incremental (ba67be45)
• 00: Full (62da15c0)

[saagarjha]

Ok so I think that solved the "I don't have a way to make a bug for this" issue. I have signed an OCA a while back, is there anything else I need to do there?

[azvegint]

Ok so I think that solved the "I don't have a way to make a bug for this" issue. I have signed an OCA a while back, is there anything else I need to do there?

It looks like you are good to go, just follow the last paragraph of the #22627 (comment)

[aivanov-jdk]

Please update the copyright line:

- * Copyright (c) 2011, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2011, 2024, Oracle and/or its affiliates. All rights reserved. 

[openjdk]

@saagarjha Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[saagarjha]

Oops I guess I wasn't supposed to rebase on top of master. Sorry :(

Anyway, I added the copyright year in. I'll hold off on /integrate just in case I'm supposed to get this reviewed again, but if it looks good I can go ahead and do that.

[aivanov-jdk]

Oops I guess I wasn't supposed to rebase on top of master. Sorry :(

You must never use git rebase for a branch being reviewed. All your commits get new hashes as the result of the rebase operation, therefore all the comments become orphaned.

The correct way is to use git merge master -m 'Merge master' after you pulled all the latest changes for master.

---

However, as the bot has warned you #22627 (comment), you're using the master branch as the base branch for your contribution. After this PR is integrated, you'll have to handle diverged branches between the master branch in openjdk/jdk and your fork if you're going to contribute any other changes.

To avoid this problem, you would create a new branch off the master branch for each bug / contribution.

[saagarjha]

/integrate

[openjdk]

@saagarjha
Your change (at version ba67be4) is now ready to be sponsored by a Committer.

[prsadhuk]

/sponsor

[openjdk]

Going to push as commit 72c59de.
Since your change was applied there have been 24 commits pushed to the master branch:

• 75cfb64: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation
• 4da6fd4: 8345423: Shenandoah: Parallelize concurrent cleanup
• ec219ae: 8346039: [BACKOUT] - [C1] LIR Operations with one input should be implemented as LIR_Op1
• 05c5678: 8345959: Make JVM_IsStaticallyLinked JVM_LEAF
• 64fad1c: 8345797: Update copyright year to 2024 for client-libs in files where it was missed
• ddf0461: 8345799: Update copyright year to 2024 for core-libs in files where it was missed
• cbab40b: 8345683: Remove special flags for files compiled for static libraries
• 08bdeed: 8345269: Fix -Wzero-as-null-pointer-constant warnings in ppc code
• e4a34e9: 8345616: Unnecessary Hashtable usage in javax.swing.text.html.parser.Element
• cce5808: 8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit
• ... and 14 more: https://git.openjdk.org/jdk/compare/f88c1c6ff86b8f29a71647e46136b6432bb67619...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk @saagarjha Pushed as commit 72c59de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.