Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed #2263

Closed
wants to merge 3 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Jan 27, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2263/head:pull/2263
$ git checkout pull/2263

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@cl4es The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org rfr Pull request is ready for review labels Jan 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay as the side effect of getPermission is not observable. Make sure to run all the tests before integrating.

@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed

Reviewed-by: alanb, dfuchs, michaelm, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • eb92368: 8259816: Typo in java.util.stream package description
  • 0eed2c3: 8259359: javac does not attribute unexpected super constructor invocation qualifier, and may crash
  • 684c855: 8260524: validate-source fails on test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java
  • 311a0a9: 8259808: Add JFR event to detect GC locker stall
  • f353fcf: 8258894: C2: Forbid GCM to move stores into loops
  • ac276bb: 8257074: Update the ByteBuffers micro benchmark

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2021
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Make sure to run jdk-tier2 (or jdk_core) just in case :-)

@cl4es
Copy link
Member Author

cl4es commented Jan 27, 2021

@AlanBateman @dfuch thanks for reviewing. Waiting for a tier1+2 test run before integration.

@seanjmullan
Copy link
Member

Will you make the same change to src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java?

@cl4es
Copy link
Member Author

cl4es commented Jan 27, 2021

Will you make the same change to src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java?

Good catch. Let's keep things consistent. :-)

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows changes LGTM too.

@cl4es
Copy link
Member Author

cl4es commented Jan 28, 2021

@seanjmullan @dfuch @Michael-Mc-Mahon @AlanBateman - thanks for reviewing!

/integrate

@openjdk openjdk bot closed this Jan 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@cl4es Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 8fe1323.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cl4es cl4es deleted the jarfile_perm branch January 28, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
5 participants