8345773: Class-File API debug printing capability

[asotona]

Class-File API lost debug printing capability with removal of the j.l.classfile.components.ClassPrinter in JDK-8345343.
This PR adds j.l.classfile.CompoundElement::toDebugString method to restore the capability.

Please review.

Thank you,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8345774 to be approved

Issues

• JDK-8345773: Class-File API debug printing capability (Enhancement - P3)
• JDK-8345774: Class-File API debug printing capability (CSR)

Reviewers

• Chen Liang (@liach - Reviewer)
• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22634/head:pull/22634
$ git checkout pull/22634

Update a local copy of the PR:
$ git checkout pull/22634
$ git pull https://git.openjdk.org/jdk.git pull/22634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22634

View PR using the GUI difftool:
$ git pr show -t 22634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22634.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345773: Class-File API debug printing capability

Reviewed-by: liach, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• d6b5264: 8345746: Remove :resourcehogs/compiler from :hotspot_slow_compiler
• 4f855d1: 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug
• a24b08f: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
• 25d9deb: 8335367: [s390] Add support for load immediate on condition instructions.
• a6277bb: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
• 165fd84: 8342987: Update --release 24 symbol information for JDK 24 build 27
• 06c44dd: 8345465: Fix performance regression on x64 after JDK-8345120
• 2979806: 8345795: Update copyright year to 2024 for hotspot in files where it was missed
• 7e73c43: 8345217: Parallel: Refactor PSParallelCompact::next_src_region
• 7d3a404: 8339019: Obsolete the UseLinuxPosixThreadCPUClocks flag
• ... and 16 more: https://git.openjdk.org/jdk/compare/69e664de14d1f9d66447937d494da8bf971ac5fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (d1f1725d)
• 02: Full - Incremental (6fdc3c43)
• 01: Full - Incremental (7c481059)
• 00: Full (c10fb8ee)

[liach]

A good permanent replacement for the exceedingly complex ClassPrinter.

[eirbjo]

Just to be abundantly clear, should the API description state that the exact format of the debug string is unspecified and subject to change?

[liach]

Just to be abundantly clear, should the API description state that the exact format of the debug string is unspecified and subject to change?

I thought the word "debug" already conveys that. You should leave this comment in CSR review as well.

[liach]

@asotona I think you can merge this PR right now; you will create another PR to backport this to 24. The backport PR cannot be merged until the late-enhancement request is approved, but this one can be.

[asotona]

Thank you for the reviews!

/integrate

[openjdk]

Going to push as commit f88c1c6.
Since your change was applied there have been 38 commits pushed to the master branch:

• e88e793: 8343148: C2: Refactor uses of "PhaseValue::con() + PhaseIdealLoop::set_ctrl()" into separate method
• 1e9204f: 8345273: Fix -Wzero-as-null-pointer-constant warnings in s390 code
• c40140e: 8334581: Remove no-arg constructor BasicSliderUI()
• 8de0622: 8345767: javax/swing/JSplitPane/4164779/JSplitPaneKeyboardNavigationTest.java fails in ubuntu22.04
• abcd23f: 8334756: javac crashed on call to non-existent generic method with explicit annotated type arg
• 2ddaa46: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
• c631719: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor
• 29d648c: 8341781: Improve Min/Max node identities
• 4c39e9f: 8344924: Default CA certificates loaded despite request to use custom keystore
• 0f03554: 8342469: Improve API documentation for java.lang.classfile.instruction
• ... and 28 more: https://git.openjdk.org/jdk/compare/69e664de14d1f9d66447937d494da8bf971ac5fe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit f88c1c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.