Skip to content

Conversation

@magicus
Copy link
Member

@magicus magicus commented Dec 9, 2024

Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed.

I have located these modified files using:

git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list

and then run a script to update the copyright year to 2024 on these files.

I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345795: Update copyright year to 2024 for hotspot in files where it was missed (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22637/head:pull/22637
$ git checkout pull/22637

Update a local copy of the PR:
$ git checkout pull/22637
$ git pull https://git.openjdk.org/jdk.git pull/22637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22637

View PR using the GUI difftool:
$ git pr show -t 22637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22637.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2024

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345795: Update copyright year to 2024 for hotspot in files where it was missed

Reviewed-by: dholmes, tschatzl, dnsimon, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2024
@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@magicus The following labels will be automatically applied to this pull request:

  • graal
  • hotspot
  • security
  • serviceability
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 9, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2024

Webrevs

@magicus
Copy link
Member Author

magicus commented Dec 9, 2024

Apologies for the force push; I accidentally pushed a commit that belonged to another branch here, and I just rolled back that commit.

Copy link
Member

@dougxc dougxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JVMCI changes look good.

@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@magicus Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2024
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the Serviceability related copyright updates (prims, SA, debugger and tests). They are good.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 9, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned the full diff and also did some random checks. Looks good. Thanks for fixing.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2024
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looked at gc files in both shared and cpu and os specific directories.

@magicus
Copy link
Member Author

magicus commented Dec 10, 2024

Thanks for all reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

Going to push as commit 2979806.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 10, 2024
@openjdk openjdk bot closed this Dec 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@magicus Pushed as commit 2979806.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the year-2024-hotspot branch December 10, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants