-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8345795: Update copyright year to 2024 for hotspot in files where it was missed #22637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
|
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@magicus The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
6181239 to
0166c68
Compare
|
Apologies for the force push; I accidentally pushed a commit that belonged to another branch here, and I just rolled back that commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JVMCI changes look good.
|
@magicus Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked at the Serviceability related copyright updates (prims, SA, debugger and tests). They are good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scanned the full diff and also did some random checks. Looks good. Thanks for fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, looked at gc files in both shared and cpu and os specific directories.
|
Thanks for all reviews! |
|
Going to push as commit 2979806.
Your commit was automatically rebased without conflicts. |
Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed.
I have located these modified files using:
and then run a script to update the copyright year to 2024 on these files.
I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22637/head:pull/22637$ git checkout pull/22637Update a local copy of the PR:
$ git checkout pull/22637$ git pull https://git.openjdk.org/jdk.git pull/22637/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22637View PR using the GUI difftool:
$ git pr show -t 22637Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22637.diff
Using Webrev
Link to Webrev Comment