Skip to content

8345805: Update copyright year to 2024 for other files where it was missed#22645

Closed
magicus wants to merge 2 commits intoopenjdk:masterfrom
magicus:year-2024-misc
Closed

8345805: Update copyright year to 2024 for other files where it was missed#22645
magicus wants to merge 2 commits intoopenjdk:masterfrom
magicus:year-2024-misc

Conversation

@magicus
Copy link
Member

@magicus magicus commented Dec 9, 2024

Some files have been modified in 2024, but the copyright year has not been properly updated. This should be fixed.

I have located these modified files using:

git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list

and then run a script to update the copyright year to 2024 on these files.

I have made a manual sampling of files in the list to verify that they have indeed been modified in 2024.

This is a "misc" bucket bug report, covering for all those files that has not been clearly assigned in some other issue. My strategy was to update the copyright year on all files in the JDK repo, and then try to the best of my ability to partition that huge chunk of files between groups. These are the remainder after I've done the large chunks. When you review, please state clearly what part of the code you are reviewing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345805: Update copyright year to 2024 for other files where it was missed (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22645/head:pull/22645
$ git checkout pull/22645

Update a local copy of the PR:
$ git checkout pull/22645
$ git pull https://git.openjdk.org/jdk.git pull/22645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22645

View PR using the GUI difftool:
$ git pr show -t 22645

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22645.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2024

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345805: Update copyright year to 2024 for other files where it was missed

Reviewed-by: dholmes, mli, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • f88c1c6: 8345773: Class-File API debug printing capability
  • e88e793: 8343148: C2: Refactor uses of "PhaseValue::con() + PhaseIdealLoop::set_ctrl()" into separate method
  • 1e9204f: 8345273: Fix -Wzero-as-null-pointer-constant warnings in s390 code
  • c40140e: 8334581: Remove no-arg constructor BasicSliderUI()
  • 8de0622: 8345767: javax/swing/JSplitPane/4164779/JSplitPaneKeyboardNavigationTest.java fails in ubuntu22.04
  • abcd23f: 8334756: javac crashed on call to non-existent generic method with explicit annotated type arg
  • 2ddaa46: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
  • c631719: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor
  • 29d648c: 8341781: Improve Min/Max node identities
  • 4c39e9f: 8344924: Default CA certificates loaded despite request to use custom keystore
  • ... and 28 more: https://git.openjdk.org/jdk/compare/830173fcb08b004ea3932d47cb522c589feec0b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2024
@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@magicus The following labels will be automatically applied to this pull request:

  • core-libs
  • graal
  • hotspot
  • net
  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org security security-dev@openjdk.org nio nio-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org net net-dev@openjdk.org labels Dec 9, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2024

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security related files look fine.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 9, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024
Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice batch cleanup!

@magicus
Copy link
Member Author

magicus commented Dec 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

Going to push as commit 8e0f929.
Since your change was applied there have been 38 commits pushed to the master branch:

  • f88c1c6: 8345773: Class-File API debug printing capability
  • e88e793: 8343148: C2: Refactor uses of "PhaseValue::con() + PhaseIdealLoop::set_ctrl()" into separate method
  • 1e9204f: 8345273: Fix -Wzero-as-null-pointer-constant warnings in s390 code
  • c40140e: 8334581: Remove no-arg constructor BasicSliderUI()
  • 8de0622: 8345767: javax/swing/JSplitPane/4164779/JSplitPaneKeyboardNavigationTest.java fails in ubuntu22.04
  • abcd23f: 8334756: javac crashed on call to non-existent generic method with explicit annotated type arg
  • 2ddaa46: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
  • c631719: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor
  • 29d648c: 8341781: Improve Min/Max node identities
  • 4c39e9f: 8344924: Default CA certificates loaded despite request to use custom keystore
  • ... and 28 more: https://git.openjdk.org/jdk/compare/830173fcb08b004ea3932d47cb522c589feec0b5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2024
@openjdk openjdk bot closed this Dec 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@magicus Pushed as commit 8e0f929.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the year-2024-misc branch December 11, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated net net-dev@openjdk.org nio nio-dev@openjdk.org security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants