8345818: Fix SM cleanup of parsing of System property resource.bundle.debug#22649
8345818: Fix SM cleanup of parsing of System property resource.bundle.debug#22649RogerRiggs wants to merge 1 commit intoopenjdk:masterfrom
Conversation
….debug Replace broken getProperty with with Boolean.getBoolean
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@RogerRiggs The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/integrate |
|
Going to push as commit 4f855d1.
Your commit was automatically rebased without conflicts. |
|
@RogerRiggs Pushed as commit 4f855d1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Replace broken getProperty with Boolean.getBoolean.
Manual testing confirms trace messages are enabled with
-Dresource.bundle.debug=trueProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22649/head:pull/22649$ git checkout pull/22649Update a local copy of the PR:
$ git checkout pull/22649$ git pull https://git.openjdk.org/jdk.git pull/22649/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22649View PR using the GUI difftool:
$ git pr show -t 22649Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22649.diff
Using Webrev
Link to Webrev Comment