Skip to content

8345818: Fix SM cleanup of parsing of System property resource.bundle.debug#22649

Closed
RogerRiggs wants to merge 1 commit intoopenjdk:masterfrom
RogerRiggs:8235818-sm-cleanup-fix-java-util
Closed

8345818: Fix SM cleanup of parsing of System property resource.bundle.debug#22649
RogerRiggs wants to merge 1 commit intoopenjdk:masterfrom
RogerRiggs:8235818-sm-cleanup-fix-java-util

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Dec 9, 2024

Replace broken getProperty with Boolean.getBoolean.

Manual testing confirms trace messages are enabled with -Dresource.bundle.debug=true


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345818: Fix SM cleanup of parsing of System property resource.bundle.debug (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22649/head:pull/22649
$ git checkout pull/22649

Update a local copy of the PR:
$ git checkout pull/22649
$ git pull https://git.openjdk.org/jdk.git pull/22649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22649

View PR using the GUI difftool:
$ git pr show -t 22649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22649.diff

Using Webrev

Link to Webrev Comment

….debug

Replace broken getProperty with with Boolean.getBoolean
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345818: Fix SM cleanup of parsing of System property resource.bundle.debug

Reviewed-by: lancea, eirbjo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • a24b08f: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
  • 25d9deb: 8335367: [s390] Add support for load immediate on condition instructions.
  • a6277bb: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
  • 165fd84: 8342987: Update --release 24 symbol information for JDK 24 build 27
  • 06c44dd: 8345465: Fix performance regression on x64 after JDK-8345120
  • 2979806: 8345795: Update copyright year to 2024 for hotspot in files where it was missed
  • 7e73c43: 8345217: Parallel: Refactor PSParallelCompact::next_src_region
  • 7d3a404: 8339019: Obsolete the UseLinuxPosixThreadCPUClocks flag
  • a606836: 8345744: Use C++ LINK_TYPE with SetupBuildLauncher in StaticLibs.gmk
  • fe0173d: 8345803: Update copyright year to 2024 for security in files where it was missed
  • ... and 7 more: https://git.openjdk.org/jdk/compare/7aa0cbc91d90493a3dae973cb8077cfa283c32b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2024
@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Dec 9, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2024

Webrevs

@RogerRiggs RogerRiggs changed the title 8345818: Fix SM cleanup of parsing of System property resource.bundle debug 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug Dec 10, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2024
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

Going to push as commit 4f855d1.
Since your change was applied there have been 17 commits pushed to the master branch:

  • a24b08f: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
  • 25d9deb: 8335367: [s390] Add support for load immediate on condition instructions.
  • a6277bb: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
  • 165fd84: 8342987: Update --release 24 symbol information for JDK 24 build 27
  • 06c44dd: 8345465: Fix performance regression on x64 after JDK-8345120
  • 2979806: 8345795: Update copyright year to 2024 for hotspot in files where it was missed
  • 7e73c43: 8345217: Parallel: Refactor PSParallelCompact::next_src_region
  • 7d3a404: 8339019: Obsolete the UseLinuxPosixThreadCPUClocks flag
  • a606836: 8345744: Use C++ LINK_TYPE with SetupBuildLauncher in StaticLibs.gmk
  • fe0173d: 8345803: Update copyright year to 2024 for security in files where it was missed
  • ... and 7 more: https://git.openjdk.org/jdk/compare/7aa0cbc91d90493a3dae973cb8077cfa283c32b4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 10, 2024
@openjdk openjdk bot closed this Dec 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@RogerRiggs Pushed as commit 4f855d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8235818-sm-cleanup-fix-java-util branch February 24, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants