Skip to content

8346567: Make Class.getModifiers() non-native #22652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

8346567: Make Class.getModifiers() non-native #22652

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec546ae
8345678: Make Class.getModifiers() non-native.
coleenp Dec 9, 2024
86bc216
Fix JFR bug.
coleenp Jan 31, 2025
8854fcc
Removed @Stable.
coleenp Feb 3, 2025
ff69341
Fix copyright and param name
coleenp Feb 4, 2025
f92620e
Update src/hotspot/share/opto/memnode.cpp
coleenp Feb 6, 2025
8502636
Add Klass::modifier_flags to look in the mirror, restore ciKlass::mod…
coleenp Feb 6, 2025
146e255
Make compute_modifiers return u2.
coleenp Feb 6, 2025
2ea6664
Hide Class.modifiers field.
coleenp Feb 6, 2025
304a17e
Remove ??? in the code.
coleenp Feb 6, 2025
37a8cf8
Fix jvmci test.
coleenp Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/hotspot/share/opto/memnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2455,7 +2455,6 @@ const Type* LoadNode::klass_value_common(PhaseGVN* phase) const {
// a primitive Class (e.g., int.class) has null for a klass field
return TypePtr::NULL_PTR;
}
// ???
// Fold up the load of the hidden field
return TypeKlassPtr::make(t->as_klass(), Type::trust_interfaces);
}
Expand Down
4 changes: 2 additions & 2 deletions src/java.base/share/classes/jdk/internal/reflect/Reflection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -56,7 +56,7 @@ public class Reflection {
fieldFilterMap = Map.of(
Reflection.class, ALL_MEMBERS,
AccessibleObject.class, ALL_MEMBERS,
Class.class, Set.of("classLoader", "classData"),
Class.class, Set.of("classLoader", "classData", "modifiers"),
ClassLoader.class, ALL_MEMBERS,
Constructor.class, ALL_MEMBERS,
Field.class, ALL_MEMBERS,
Expand Down
5 changes: 3 additions & 2 deletions test/jdk/jdk/internal/reflect/Reflection/Filtering.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -23,7 +23,7 @@

/**
* @test
* @bug 8210496
* @bug 8210496 8346567
* @modules java.base/jdk.internal.reflect
* @run testng Filtering
* @summary Test that security sensitive fields that filtered by core reflection
Expand Down Expand Up @@ -55,6 +55,7 @@ private Object[][] sensitiveFields() {
{ AccessibleObject.class, "override" },
{ Class.class, "classLoader" },
{ Class.class, "classData" },
{ Class.class, "modifiers" },
{ ClassLoader.class, "parent" },
{ Field.class, "clazz" },
{ Field.class, "modifiers" },
Expand Down