Skip to content

8346567: Make Class.getModifiers() non-native #22652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

8346567: Make Class.getModifiers() non-native #22652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec546ae
8345678: Make Class.getModifiers() non-native.
coleenp Dec 9, 2024
86bc216
Fix JFR bug.
coleenp Jan 31, 2025
8854fcc
Removed @Stable.
coleenp Feb 3, 2025
ff69341
Fix copyright and param name
coleenp Feb 4, 2025
f92620e
Update src/hotspot/share/opto/memnode.cpp
coleenp Feb 6, 2025
8502636
Add Klass::modifier_flags to look in the mirror, restore ciKlass::mod…
coleenp Feb 6, 2025
146e255
Make compute_modifiers return u2.
coleenp Feb 6, 2025
2ea6664
Hide Class.modifiers field.
coleenp Feb 6, 2025
304a17e
Remove ??? in the code.
coleenp Feb 6, 2025
37a8cf8
Fix jvmci test.
coleenp Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/instanceKlass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3338,7 +3338,7 @@ InstanceKlass* InstanceKlass::compute_enclosing_class(bool* inner_is_member, TRA
return outer_klass;
}

int InstanceKlass::compute_modifier_flags() const {
u2 InstanceKlass::compute_modifier_flags() const {
u2 access = access_flags().as_unsigned_short();

// But check if it happens to be member class.
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/instanceKlass.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,7 @@ class InstanceKlass: public Klass {
void compute_has_loops_flag_for_methods();
#endif

int compute_modifier_flags() const;
u2 compute_modifier_flags() const;

public:
// JVMTI support
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/klass.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ class Klass : public Metadata {
virtual void release_C_heap_structures(bool release_constant_pool = true);

public:
virtual int compute_modifier_flags() const = 0;
virtual u2 compute_modifier_flags() const = 0;
int modifier_flags() const;

// JVMTI support
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/objArrayKlass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ void ObjArrayKlass::metaspace_pointers_do(MetaspaceClosure* it) {
it->push(&_bottom_klass);
}

int ObjArrayKlass::compute_modifier_flags() const {
u2 ObjArrayKlass::compute_modifier_flags() const {
// The modifier for an objectArray is the same as its element
assert (element_klass() != nullptr, "should be initialized");

Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/objArrayKlass.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class ObjArrayKlass : public ArrayKlass {
inline void oop_oop_iterate_elements_bounded(objArrayOop a, OopClosureType* closure, void* low, void* high);

public:
int compute_modifier_flags() const;
u2 compute_modifier_flags() const;

public:
// Printing
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/typeArrayKlass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ TypeArrayKlass* TypeArrayKlass::allocate(ClassLoaderData* loader_data, BasicType
return new (loader_data, size, THREAD) TypeArrayKlass(type, name);
}

int TypeArrayKlass::compute_modifier_flags() const {
u2 TypeArrayKlass::compute_modifier_flags() const {
return JVM_ACC_ABSTRACT | JVM_ACC_FINAL | JVM_ACC_PUBLIC;
}

Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/typeArrayKlass.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class TypeArrayKlass : public ArrayKlass {
jint max_length() { return _max_length; }
void set_max_length(jint m) { _max_length = m; }

int compute_modifier_flags() const;
u2 compute_modifier_flags() const;

// testers
DEBUG_ONLY(bool is_typeArray_klass_slow() const { return true; })
Expand Down