Skip to content

8346567: Make Class.getModifiers() non-native #22652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

8346567: Make Class.getModifiers() non-native #22652

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec546ae
8345678: Make Class.getModifiers() non-native.
coleenp Dec 9, 2024
86bc216
Fix JFR bug.
coleenp Jan 31, 2025
8854fcc
Removed @Stable.
coleenp Feb 3, 2025
ff69341
Fix copyright and param name
coleenp Feb 4, 2025
f92620e
Update src/hotspot/share/opto/memnode.cpp
coleenp Feb 6, 2025
8502636
Add Klass::modifier_flags to look in the mirror, restore ciKlass::mod…
coleenp Feb 6, 2025
146e255
Make compute_modifiers return u2.
coleenp Feb 6, 2025
2ea6664
Hide Class.modifiers field.
coleenp Feb 6, 2025
304a17e
Remove ??? in the code.
coleenp Feb 6, 2025
37a8cf8
Fix jvmci test.
coleenp Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/opto/memnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2456,7 +2456,7 @@ const Type* LoadNode::klass_value_common(PhaseGVN* phase) const {
return TypePtr::NULL_PTR;
}
// ???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that we still need this code to support intrinsics like LibraryCallKit::inline_native_classID() and maybe other users of this field, but the comment below no longer makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing the ??? that I left in and the comment.

// (Folds up the 1st indirection in aClassConstant.getModifiers().)
// Fold up the load of the hidden field
return TypeKlassPtr::make(t->as_klass(), Type::trust_interfaces);
}
// non-constant mirror, so we can't tell what's going on
Expand Down