Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345908: Class links should be properly spaced #22662

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Dec 10, 2024

Please review a trivial change to apply monospace font not just to the class links at the top of class and interface pages, but also to the comma and space characters between them. The comma-space separators currently use proportional font, which results in very narrow spacing that does not match the class name font.

Using the same monospace font for everything makes individual class names more discernible, and makes it easier to pick out individual class names. This is especially true for multiline class lists such as the subinterfaces of java.lang.Autoclosable below.

Before:

class-links-old

After:

class-links-new

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345908: Class links should be properly spaced (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22662/head:pull/22662
$ git checkout pull/22662

Update a local copy of the PR:
$ git checkout pull/22662
$ git pull https://git.openjdk.org/jdk.git pull/22662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22662

View PR using the GUI difftool:
$ git pr show -t 22662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22662.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2024

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345908: Class links should be properly spaced

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • 68aa4d4: 8346063: java/lang/Thread/virtual/Starvation.java missing @requires vm.continuations
  • 77e4932: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_.cpp file
  • 3f2556b: 8345984: Remove redundant checkXXX methods from java.management Util class
  • ceb4366: 8345955: Deprecate the UseOprofile flag with a view to removing the legacy oprofile support in the VM
  • 72c59de: 8345876: Update nativeAddAtIndex comment to match the code
  • 75cfb64: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation
  • 4da6fd4: 8345423: Shenandoah: Parallelize concurrent cleanup
  • ec219ae: 8346039: [BACKOUT] - [C1] LIR Operations with one input should be implemented as LIR_Op1
  • 05c5678: 8345959: Make JVM_IsStaticallyLinked JVM_LEAF
  • 64fad1c: 8345797: Update copyright year to 2024 for client-libs in files where it was missed
  • ... and 36 more: https://git.openjdk.org/jdk/compare/a6277bb521e07e569cd75a4641b2a05a26f47b0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Dec 10, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2024
@hns
Copy link
Member Author

hns commented Dec 12, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

Going to push as commit b8bb51e.
Since your change was applied there have been 50 commits pushed to the master branch:

  • ef6e987: 8346040: Zero interpreter build on Linux Aarch64 is broken
  • f7f07b9: 8345804: Update copyright year to 2024 for langtools in files where it was missed
  • 1bdb7b4: 8345622: test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java should set processorpath to work correctly in the agentvm mode
  • 0ad6423: 8345944: JEP 492: extending local class in a different static context should not be allowed
  • 68aa4d4: 8346063: java/lang/Thread/virtual/Starvation.java missing @requires vm.continuations
  • 77e4932: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_.cpp file
  • 3f2556b: 8345984: Remove redundant checkXXX methods from java.management Util class
  • ceb4366: 8345955: Deprecate the UseOprofile flag with a view to removing the legacy oprofile support in the VM
  • 72c59de: 8345876: Update nativeAddAtIndex comment to match the code
  • 75cfb64: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation
  • ... and 40 more: https://git.openjdk.org/jdk/compare/a6277bb521e07e569cd75a4641b2a05a26f47b0a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2024
@openjdk openjdk bot closed this Dec 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@hns Pushed as commit b8bb51e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants