Skip to content

8345818: Fix SM cleanup of parsing of System property resource.bundle.debug#22664

Closed
RogerRiggs wants to merge 1 commit intoopenjdk:jdk24from
openjdk-bots:backport-RogerRiggs-4f855d13-jdk24
Closed

8345818: Fix SM cleanup of parsing of System property resource.bundle.debug#22664
RogerRiggs wants to merge 1 commit intoopenjdk:jdk24from
openjdk-bots:backport-RogerRiggs-4f855d13-jdk24

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Dec 10, 2024

Backport this trivial fix to parsing of the system property "resource.bundle.debug" to jdk24.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345818: Fix SM cleanup of parsing of System property resource.bundle.debug (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22664/head:pull/22664
$ git checkout pull/22664

Update a local copy of the PR:
$ git checkout pull/22664
$ git pull https://git.openjdk.org/jdk.git pull/22664/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22664

View PR using the GUI difftool:
$ git pr show -t 22664

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22664.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345818: Fix SM cleanup of parsing of System property resource.bundle.debug

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk24 branch:

  • 6fdfa72: 8345773: Class-File API debug printing capability
  • 950c8ad: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
  • 03bdee0: 8342469: Improve API documentation for java.lang.classfile.instruction
  • 4ecb28c: 8344924: Default CA certificates loaded despite request to use custom keystore
  • ba02e0b: 8345794: Backout doc change introduced by JDK-8235786

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4f855d1342d55aeee93b7d0c5796fbfd4994c856 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Dec 10, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2024

Webrevs

@RogerRiggs
Copy link
Contributor Author

@LanceAndersen Please review

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2024
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

Going to push as commit 3b53ed7.
Since your change was applied there have been 5 commits pushed to the jdk24 branch:

  • 6fdfa72: 8345773: Class-File API debug printing capability
  • 950c8ad: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
  • 03bdee0: 8342469: Improve API documentation for java.lang.classfile.instruction
  • 4ecb28c: 8344924: Default CA certificates loaded despite request to use custom keystore
  • ba02e0b: 8345794: Backout doc change introduced by JDK-8235786

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2024
@openjdk openjdk bot closed this Dec 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@RogerRiggs Pushed as commit 3b53ed7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants