-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342469: Improve API documentation for java.lang.classfile.instruction #22671
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Thanks for the reviews! /integrate |
Hi all,
This pull request contains a backport of commit 0f035545 from the openjdk/jdk repository.
This is a noreg-doc backport - these additions are clarifications to the ClassFile API's java.lang.classfile.instruction package, and are permissible in RDP1 and RDP2.
The commit being backported was authored by Chen Liang on 10 Dec 2024 and was reviewed by Adam Sotona and Joe Darcy.
Thanks!
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22671/head:pull/22671
$ git checkout pull/22671
Update a local copy of the PR:
$ git checkout pull/22671
$ git pull https://git.openjdk.org/jdk.git pull/22671/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22671
View PR using the GUI difftool:
$ git pr show -t 22671
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22671.diff
Using Webrev
Link to Webrev Comment