Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342469: Improve API documentation for java.lang.classfile.instruction #22671

Closed

Conversation

liach
Copy link
Member

@liach liach commented Dec 10, 2024

Hi all,

This pull request contains a backport of commit 0f035545 from the openjdk/jdk repository.

This is a noreg-doc backport - these additions are clarifications to the ClassFile API's java.lang.classfile.instruction package, and are permissible in RDP1 and RDP2.

The commit being backported was authored by Chen Liang on 10 Dec 2024 and was reviewed by Adam Sotona and Joe Darcy.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8344373 to be approved

Issues

  • JDK-8342469: Improve API documentation for java.lang.classfile.instruction (Sub-task - P4)
  • JDK-8344373: Improve API documentation for java.lang.classfile.instruction (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22671/head:pull/22671
$ git checkout pull/22671

Update a local copy of the PR:
$ git checkout pull/22671
$ git pull https://git.openjdk.org/jdk.git pull/22671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22671

View PR using the GUI difftool:
$ git pr show -t 22671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22671.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2024

👋 Welcome back liach! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342469: Improve API documentation for java.lang.classfile.instruction

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk24 branch:

  • 4ecb28c: 8344924: Default CA certificates loaded despite request to use custom keystore

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0f035545e5c0cd02d11ab8edd5786c1f1f6043a7 8342469: Improve API documentation for java.lang.classfile.instruction Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 10, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024
@liach
Copy link
Member Author

liach commented Dec 11, 2024

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

Going to push as commit 03bdee0.
Since your change was applied there has been 1 commit pushed to the jdk24 branch:

  • 4ecb28c: 8344924: Default CA certificates loaded despite request to use custom keystore

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2024
@openjdk openjdk bot closed this Dec 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@liach Pushed as commit 03bdee0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants