-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345773: Class-File API debug printing capability #22675
8345773: Class-File API debug printing capability #22675
Conversation
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However, we need to wait until the late enhancement is approved to integrate this.
Thank you for the review and the late enhancement approval! /integrate |
Going to push as commit 6fdfa72.
Your commit was automatically rebased without conflicts. |
Class-File API lost debug printing capability with removal of the j.l.classfile.components.ClassPrinter in JDK-8345343.
This is a backport of f88c1c6, reviewed by @liach and @mcimadamore.
Because this JDK 24 RFE comes after RDP1, it is pending approval of a later enhancement.
Thank you,
Adam
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22675/head:pull/22675
$ git checkout pull/22675
Update a local copy of the PR:
$ git checkout pull/22675
$ git pull https://git.openjdk.org/jdk.git pull/22675/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22675
View PR using the GUI difftool:
$ git pr show -t 22675
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22675.diff
Using Webrev
Link to Webrev Comment