Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345773: Class-File API debug printing capability #22675

Closed

Conversation

asotona
Copy link
Member

@asotona asotona commented Dec 11, 2024

Class-File API lost debug printing capability with removal of the j.l.classfile.components.ClassPrinter in JDK-8345343.

This is a backport of f88c1c6, reviewed by @liach and @mcimadamore.

Because this JDK 24 RFE comes after RDP1, it is pending approval of a later enhancement.

Thank you,
Adam


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8345774 to be approved

Issues

  • JDK-8345773: Class-File API debug printing capability (Enhancement - P3)
  • JDK-8345774: Class-File API debug printing capability (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22675/head:pull/22675
$ git checkout pull/22675

Update a local copy of the PR:
$ git checkout pull/22675
$ git pull https://git.openjdk.org/jdk.git pull/22675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22675

View PR using the GUI difftool:
$ git pr show -t 22675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22675.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2024

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345773: Class-File API debug printing capability

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f88c1c6ff86b8f29a71647e46136b6432bb67619 8345773: Class-File API debug printing capability Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@asotona The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 11, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2024

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, we need to wait until the late enhancement is approved to integrate this.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024
@asotona
Copy link
Member Author

asotona commented Dec 12, 2024

Thank you for the review and the late enhancement approval!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

Going to push as commit 6fdfa72.
Since your change was applied there have been 2 commits pushed to the jdk24 branch:

  • 950c8ad: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
  • 03bdee0: 8342469: Improve API documentation for java.lang.classfile.instruction

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2024
@openjdk openjdk bot closed this Dec 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@asotona Pushed as commit 6fdfa72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants