Skip to content

Conversation

@reinrich
Copy link
Member

@reinrich reinrich commented Dec 11, 2024

This pr updates the SAP SE copyright year in files that where changed in 2024 but the update was forgotten.

I used the following command to find the files

git log '--since=Jan 1' --name-only --pretty=format:    \
    --author asteiner                                   \
    --author azeller                                    \
    --author clanger                                    \
    --author goetz                                      \
    --author jbechberger                                \
    --author jkern                                      \
    --author lucy                                       \
    --author mdoerr                                     \
    --author mbaesken                                   \
    --author rrich                                      \
    --author rschmelter                                 \
    --author andrewlu                                   \
    --author ashi                                       \
     | sort -u | xargs grep -l 'SAP SE'

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345975: Update SAP SE copyright year to 2024 where it was missed (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22677/head:pull/22677
$ git checkout pull/22677

Update a local copy of the PR:
$ git checkout pull/22677
$ git pull https://git.openjdk.org/jdk.git pull/22677/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22677

View PR using the GUI difftool:
$ git pr show -t 22677

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22677.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2024

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345975: Update SAP SE copyright year to 2024 where it was missed

Reviewed-by: mdoerr, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c9ec271: 8345800: Update copyright year to 2024 for serviceability in files where it was missed
  • 8e0f929: 8345805: Update copyright year to 2024 for other files where it was missed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@reinrich The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 11, 2024
@reinrich reinrich marked this pull request as ready for review December 11, 2024 10:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024
@reinrich
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit ee1c5ad.
Since your change was applied there have been 60 commits pushed to the master branch:

  • 3518b4b: 8344171: Clone and initialize Assertion Predicates in order instead of in reverse-order
  • c88e081: 8346160: Fix -Wzero-as-null-pointer-constant warnings from explicit casts
  • ab1dbd4: 8346202: Correct typo in SQLPermission
  • 6b022bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
  • 3b9de11: 8319875: Add macOS implementation for jcmd System.map
  • ebb27c2: 8346139: test_memset_with_concurrent_readers.cpp should not use
  • c2f0ef5: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635
  • 4b21fb9: 8343467: Remove unnecessary @SuppressWarnings annotations (security)
  • e7fc0eb: 8345987: java.management has two Util.newObjectName methods (remove one)
  • f647d4d: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar
  • ... and 50 more: https://git.openjdk.org/jdk/compare/f88c1c6ff86b8f29a71647e46136b6432bb67619...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@reinrich Pushed as commit ee1c5ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinrich reinrich deleted the update_sap_copyright_year branch October 24, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants