8257746: Regression introduced with JDK-8250984 - memory might be null in some machines #2269
@poonamparhar This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the
@poonamparhar Since your change was applied there have been 23 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit abc4300.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
This isn't very satisfying, though. How can we be sure this issue isn't also present in the cgroup v2 code? Has this been tested? Surely, there was some stack trace reported by the customer or some sort of reproducer got provided. What was the reasoning that established this issue is present in JDK head and only in cgroups v1 code? My guess is that the issue got triggered via the OperatingSystemMXBean, but nothing to that effect has been noted here or in the bug.
If I were to propose such a point fix, clearly, I'd have to provide some details what the actual problem is and explain why the fix is sufficient and covers all branches. All that got provided is: "But memory could be Null on some machines that have cgroup entries for CPU but not for memory."
I can check with the customer if they could share their config.
The cgroups v2 code was thoroughly examined and this problem does not exist in that code. cgroups v2 does not have a separate MemorySubSystemController as we have for c1 cgroups.
An instance of the CgroupV1MemorySubSystemController is stored as a member in CgroupV1Subsystem.
This memory instance variable could stay null if "memory" entry is not found while creating sub-system objects in createSubSystemController().
This fix ensure that the memory instance is not null before invoking any method on it.
Such problem does not exist in cgroups v2 code.
That would be helpful. A stack trace of the NPE would be good too.
Right, but is this reasoning sound? Without knowing the code path triggering the problem and knowing something about the config can we really say? Depending on the config it might fail in some very different way on cgroups v2!
On the other hand, knowing the config, might allow us to conclude it's an impossible config on cgroups v2 and we are done.