8346040: Zero interpreter build on Linux Aarch64 is broken

[coleenp]

This fixes the zero build for aarch64.
Mach5 tier1 testing on Oracle platforms (including aarch64) in progress.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346040: Zero interpreter build on Linux Aarch64 is broken (Bug - P3)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22692/head:pull/22692
$ git checkout pull/22692

Update a local copy of the PR:
$ git checkout pull/22692
$ git pull https://git.openjdk.org/jdk.git pull/22692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22692

View PR using the GUI difftool:
$ git pr show -t 22692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22692.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346040: Zero interpreter build on Linux Aarch64 is broken

Reviewed-by: kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• ceb4366: 8345955: Deprecate the UseOprofile flag with a view to removing the legacy oprofile support in the VM
• 72c59de: 8345876: Update nativeAddAtIndex comment to match the code
• 75cfb64: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation
• 4da6fd4: 8345423: Shenandoah: Parallelize concurrent cleanup
• ec219ae: 8346039: [BACKOUT] - [C1] LIR Operations with one input should be implemented as LIR_Op1
• 05c5678: 8345959: Make JVM_IsStaticallyLinked JVM_LEAF
• 64fad1c: 8345797: Update copyright year to 2024 for client-libs in files where it was missed
• ddf0461: 8345799: Update copyright year to 2024 for core-libs in files where it was missed
• cbab40b: 8345683: Remove special flags for files compiled for static libraries

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2f024b45)

[kimbarrett]

Looks good.

[dholmes-ora]

This appears to fix the immediate problem, but I'm unclear why we need a special API for one architecture, or why it resides in shared code. ??

[coleenp]

There's an optimization/bug fix in aarch64 macroAssembly code that reduces the number of instructions in encoding and decoding klass pointers: JDK-8234794. The constraints it adds are not in shared code.
Thanks for reviewing.
/integrate

[openjdk]

Going to push as commit ef6e987.
Since your change was applied there have been 15 commits pushed to the master branch:

• f7f07b9: 8345804: Update copyright year to 2024 for langtools in files where it was missed
• 1bdb7b4: 8345622: test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java should set processorpath to work correctly in the agentvm mode
• 0ad6423: 8345944: JEP 492: extending local class in a different static context should not be allowed
• 68aa4d4: 8346063: java/lang/Thread/virtual/Starvation.java missing @requires vm.continuations
• 77e4932: 8344026: Ubsan: prevent potential integer overflow in c1_LIRGenerator_.cpp file
• 3f2556b: 8345984: Remove redundant checkXXX methods from java.management Util class
• ceb4366: 8345955: Deprecate the UseOprofile flag with a view to removing the legacy oprofile support in the VM
• 72c59de: 8345876: Update nativeAddAtIndex comment to match the code
• 75cfb64: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation
• 4da6fd4: 8345423: Shenandoah: Parallelize concurrent cleanup
• ... and 5 more: https://git.openjdk.org/jdk/compare/08bdeedfd355b61f7cdabbe943657691e5af2c82...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit ef6e987.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.