8345432: (ch, fs) Replace anonymous Thread with InnocuousThread

[bplb]

Change internal instances of anonymous Threads to instances of InnocuousThread.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8346124 to be approved

Issues

• JDK-8345432: (ch, fs) Replace anonymous Thread with InnocuousThread (Enhancement - P4)
• JDK-8346124: (ch, fs) Replace anonymous Thread with InnocuousThread (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22697/head:pull/22697
$ git checkout pull/22697

Update a local copy of the PR:
$ git checkout pull/22697
$ git pull https://git.openjdk.org/jdk.git pull/22697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22697

View PR using the GUI difftool:
$ git pr show -t 22697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22697.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

The loopback connector thread in the Windows version of PipeImpl still uses an anonymous thread as it overrides interrupt() to do nothing.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345432: (ch, fs) Replace anonymous Thread with InnocuousThread

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 185 new commits pushed to the master branch:

• 9c393a2: 8346953: Remove unnecessary @SuppressWarnings annotations (client, Make "can write" check work on Windows #2)
• 9a60f44: 8345668: ZoneOffset.ofTotalSeconds performance regression
• 12700cb: 8346264: "Total compile time" counter should include time spent in failing/bailout compiles
• dd81f8d: 8344079: Minor fixes and cleanups to compiler lint-related code
• ccf3d57: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API
• 594e519: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks
• c027f2e: 8346983: Remove ASM-based transforms from Class-File API tests
• e0695e0: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
• dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
• f1d85ab: 8346773: Fix unmatched brackets in some misc files
• ... and 175 more: https://git.openjdk.org/jdk/compare/d6b5264c3f7d0c4157ebd73b2f1a98dd15273c61...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (c4196757)
• 02: Full - Incremental (aa5bb8a1)
• 01: Full - Incremental (7a421c1d)
• 00: Full (01dad84b)

[bplb]

The loopback connector thread in the Windows version of PipeImpl still uses an anonymous thread as it overrides interrupt() to do nothing.

@AlanBateman , do you have any comment on this?

[AlanBateman]

The loopback connector thread in the Windows version of PipeImpl still uses an anonymous thread as it overrides interrupt() to do nothing.

@AlanBateman , do you have any comment on this?

It's short lived so any inheritance isn't going to cause memory to be retained. On balance, it's probably best to convert this one while you are in the area, avoids questions in the future.

[bplb]

On balance, it's probably best to convert this one while you are in the area, avoids questions in the future.

It is not clear how to deal with interrupt() here as InnocuousThread is final. Something like

private boolean isInterruptible;

public void interrupt() {
    if (isInterruptible)
        super.interrupt();
}

does not seem like a good idea.

[bplb]

It's unclear to me whether the number of changes in aa5bb8a is worthwhile for this.

[bplb]

/integrate

[openjdk]

Going to push as commit d723597.
Since your change was applied there have been 185 commits pushed to the master branch:

• 9c393a2: 8346953: Remove unnecessary @SuppressWarnings annotations (client, Make "can write" check work on Windows #2)
• 9a60f44: 8345668: ZoneOffset.ofTotalSeconds performance regression
• 12700cb: 8346264: "Total compile time" counter should include time spent in failing/bailout compiles
• dd81f8d: 8344079: Minor fixes and cleanups to compiler lint-related code
• ccf3d57: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API
• 594e519: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks
• c027f2e: 8346983: Remove ASM-based transforms from Class-File API tests
• e0695e0: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
• dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
• f1d85ab: 8346773: Fix unmatched brackets in some misc files
• ... and 175 more: https://git.openjdk.org/jdk/compare/d6b5264c3f7d0c4157ebd73b2f1a98dd15273c61...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit d723597.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.