Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345944: JEP 492: extending local class in a different static context should not be allowed #22708

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Dec 12, 2024

This is a simple backport of this commit


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8345944: JEP 492: extending local class in a different static context should not be allowed (Bug - P3)
  • JDK-8345953: JEP 492: instantiating local classes in a different static context should not be allowed (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22708/head:pull/22708
$ git checkout pull/22708

Update a local copy of the PR:
$ git checkout pull/22708
$ git pull https://git.openjdk.org/jdk.git pull/22708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22708

View PR using the GUI difftool:
$ git pr show -t 22708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22708.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345944: JEP 492: extending local class in a different static context should not be allowed
8345953: JEP 492: instantiating local classes in a different static context should not be allowed

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk24 branch:

  • 6fdfa72: 8345773: Class-File API debug printing capability

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0ad64234e2fd19ec0435fb00340120153b928f9c 8345944: JEP 492: extending local class in a different static context should not be allowed Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@mcimadamore The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Dec 12, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2024

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2024
@mcimadamore
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit 67b8251.
Since your change was applied there have been 6 commits pushed to the jdk24 branch:

  • 6e8aad1: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used
  • 4d6eccd: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635
  • 6bc14d6: 8345888: Broken links in the JDK 24 JavaDoc API documentation, build 27
  • 897a8ab: 8346040: Zero interpreter build on Linux Aarch64 is broken
  • 3b53ed7: 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug
  • 6fdfa72: 8345773: Class-File API debug printing capability

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@mcimadamore Pushed as commit 67b8251.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants