-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345944: JEP 492: extending local class in a different static context should not be allowed #22708
8345944: JEP 492: extending local class in a different static context should not be allowed #22708
Conversation
👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into |
@mcimadamore This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issues from the original commit. |
@mcimadamore The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/integrate |
Going to push as commit 67b8251.
Your commit was automatically rebased without conflicts. |
@mcimadamore Pushed as commit 67b8251. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a simple backport of this commit
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22708/head:pull/22708
$ git checkout pull/22708
Update a local copy of the PR:
$ git checkout pull/22708
$ git pull https://git.openjdk.org/jdk.git pull/22708/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22708
View PR using the GUI difftool:
$ git pr show -t 22708
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22708.diff
Using Webrev
Link to Webrev Comment