Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256421: Add 2 HARICA roots to cacerts truststore #2272

Closed
wants to merge 1 commit into from
Closed

8256421: Add 2 HARICA roots to cacerts truststore #2272

wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jan 28, 2021

Following two roots are added to cacerts store -

CN=Hellenic Academic and Research Institutions RootCA 2015, O=Hellenic Academic and Research Institutions Cert. Authority, L=Athens, C=GR

CN=Hellenic Academic and Research Institutions ECC RootCA 2015, O=Hellenic Academic and Research Institutions Cert. Authority, L=Athens, C=GR

Release Note is at - https://bugs.openjdk.java.net/browse/JDK-8260597


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256421: Add 2 HARICA roots to cacerts truststore

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2272/head:pull/2272
$ git checkout pull/2272

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2021

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@rhalade The following labels will be automatically applied to this pull request:

  • build
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org labels Jan 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2021

Webrevs

@rhalade
Copy link
Member Author

rhalade commented Jan 28, 2021

/test builds

@rhalade
Copy link
Member Author

rhalade commented Jan 28, 2021

/test tier2

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@rhalade the test group tier2 does not exist

@magicus
Copy link
Member

magicus commented Jan 28, 2021

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@magicus
The build label was successfully removed.

@haimaychao
Copy link
Contributor

Looks good.

@rhalade
Copy link
Member Author

rhalade commented Jan 28, 2021

Looks good.

Thanks!! Can you please approve review with approval on changeset? With that, your OpenJDK id will be added as reviewer to the fix.

@rhalade
Copy link
Member Author

rhalade commented Feb 2, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@rhalade This PR has not yet been marked as ready for integration.

@rhalade rhalade changed the title 8256421: Add 2 HARICA roots to Oracle Root CA Program 8256421: Add 2 HARICA roots to cacerts truststore Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256421: Add 2 HARICA roots to cacerts truststore

Reviewed-by: hchao, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
  • d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
  • 0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
  • defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
  • a421bfa: 8259839: SystemDictionary exports too much implementation
  • 189b65b: 8260264: Move common os_ inline methods to a common posix source file
  • 288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
  • ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • fe407cf: 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 474dba2: 8257086: Clarify differences between {Float, Double}.equals and ==
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/eb9236853cfada574e7697e925f9eca9743fa923...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2021
@rhalade
Copy link
Member Author

rhalade commented Feb 2, 2021

/integrate

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2021
@rhalade rhalade deleted the 8256421 branch February 2, 2021 18:26
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@rhalade Since your change was applied there have been 78 commits pushed to the master branch:

  • f546fd0: 8260902: CDS mapping errors should not lead to unconditional output
  • d7b1fc5: 8260707: java/lang/instrument/PremainClass/InheritAgent0100.java times out
  • 0093183: 8260368: [PPC64] GC interface needs enhancement to support GCs with load barriers
  • defcb04: 8260867: ProblemList java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java on linux
  • a421bfa: 8259839: SystemDictionary exports too much implementation
  • 189b65b: 8260264: Move common os_ inline methods to a common posix source file
  • 288a4fe: 8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()
  • ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • fe407cf: 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 474dba2: 8257086: Clarify differences between {Float, Double}.equals and ==
  • ... and 68 more: https://git.openjdk.java.net/jdk/compare/eb9236853cfada574e7697e925f9eca9743fa923...master

Your commit was automatically rebased without conflicts.

Pushed as commit 69189f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants