8346046: Enable copyright header format check

[zhaosongzs]

As requested in SKARA-1357, now skara bot is able to check the copyright header format.
Now I am going to update the jcheck configuration to configure copyright check as an error.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8346046: Enable copyright header format check (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22721/head:pull/22721
$ git checkout pull/22721

Update a local copy of the PR:
$ git checkout pull/22721
$ git pull https://git.openjdk.org/jdk.git pull/22721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22721

View PR using the GUI difftool:
$ git pr show -t 22721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22721.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhaosongzs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346046: Enable copyright header format check

Reviewed-by: erikj, iris, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 57adf64: 8346261: Cleanup in JDP tests
• 23708d0: 8346257: Problemlist jdp tests for macosx-aarch64
• f8974ba: 8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test
• e7d21fc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
• cb92595: 8336356: [s390x] preserve Vector Register before using for string compress / expand
• d737978: 8343477: Remove unnecessary @SuppressWarnings annotations (compiler)
• 8133eb2: 8346150: Jib dependency on autoconf missing for 'docs' profile
• 45a3297: 8346248: serviceability/dcmd/vm/{SystemMapTest.java,SystemMapTest.java} failing on macos-aarch64
• dbffe33: 8345263: Make sure that lint categories are used correctly when logging lint warnings
• 32c8195: 8345801: C2: Clean up include statements to speed up compilation when touching type.hpp
• ... and 43 more: https://git.openjdk.org/jdk/compare/64fad1c7d374bbc635bad3b1fa7941379f39565f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @irisclark, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@zhaosongzs The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (62a26436)
• 00: Full (de49714d)

[erikj79]

I think this looks ok, but would like input from at least another reviewer.

/reviewers 2

[openjdk]

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[dholmes-ora]

IIUC there are other special files that could be excluded here: .icon, .tiff, .dat

But, again IIUC, this is just an optimization as the check would be "if the file has what appears to be an Oracle copyright, then validate the format". So binary files would not have it and so would not be validated.

[zhaosongzs]

Yes, your understanding is correct. Additionally, Skara won't attempt to check binary files.

[zhaosongzs]

Thank you all for the reviews!
/integrate

[openjdk]

@zhaosongzs
Your change (at version 62a2643) is now ready to be sponsored by a Committer.

[erikj79]

/sponsor

[openjdk]

Going to push as commit 18d1d61.
Since your change was applied there have been 61 commits pushed to the master branch:

• a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
• 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
• 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
• fd0207d: 8345327: JDK 24 RDP1 L10n resource files update
• 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
• c75b1d4: 8346082: Output JVMTI agent information in hserr files
• 51662c2: 8346232: Remove leftovers of the jar --normalize feature
• d335941: 8345678: compute_modifiers should not be in create_mirror
• 57adf64: 8346261: Cleanup in JDP tests
• 23708d0: 8346257: Problemlist jdp tests for macosx-aarch64
• ... and 51 more: https://git.openjdk.org/jdk/compare/64fad1c7d374bbc635bad3b1fa7941379f39565f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 @zhaosongzs Pushed as commit 18d1d61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.