8346142: [perf] scalability issue for the specjvm2008::xml.validation workload

[IvaVladimir]

The double check needs less time vs enter to 'synchronize' block when it not needed. This patch for the xml.validation workload for runs with 112 threads reports ~2.5% improvement on the server with Xeon 8480:
orig: 1T - 433.64 ops/m, 112T - 17344.25 ops/m
patched: 1T - 437.01 ops/m, 112T - 17771.94 ops/m

The tier1 and jaxp tests are OK with this patch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346142: [perf] scalability issue for the specjvm2008::xml.validation workload (Bug - P4)

Reviewers

• Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22723/head:pull/22723
$ git checkout pull/22723

Update a local copy of the PR:
$ git checkout pull/22723
$ git pull https://git.openjdk.org/jdk.git pull/22723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22723

View PR using the GUI difftool:
$ git pr show -t 22723

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22723.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vaivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@IvaVladimir This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346142: [perf] scalability issue for the specjvm2008::xml.validation workload

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 279 new commits pushed to the master branch:

• 9b1bed0: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached"
• 2de71d0: 8347129: cpuset cgroups controller is required for no good reason
• 4c30933: 8346971: [ubsan] psCardTable.cpp:131:24: runtime error: large index is out of bounds
• 06ff4c1: 8347146: Convert IncludeLocalesPluginTest to use JUnit
• db76f47: 8347720: [BACKOUT] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• e6902cf: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order
• a01e92c: 8347724: Replace SIZE_FORMAT in jfr directory
• d002933: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• d532019: 8347143: [aix] Fix strdup use in os::dll_load
• dfd215b: 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
• ... and 269 more: https://git.openjdk.org/jdk/compare/db9eab3f29e9cb26a8c0a7c31c55aaf140f21bed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@IvaVladimir The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (20554293)
• 00: Full (0e73a89a)

[bridgekeeper]

@IvaVladimir This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[JoeWang-Java]

Nice improvement!

[IvaVladimir]

/integrate

Thanks for your review!

[openjdk]

@IvaVladimir
Your change (at version 2055429) is now ready to be sponsored by a Committer.

[dwhite-intel]

/sponsor

[openjdk]

Going to push as commit 10d08db.
Since your change was applied there have been 279 commits pushed to the master branch:

• 9b1bed0: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached"
• 2de71d0: 8347129: cpuset cgroups controller is required for no good reason
• 4c30933: 8346971: [ubsan] psCardTable.cpp:131:24: runtime error: large index is out of bounds
• 06ff4c1: 8347146: Convert IncludeLocalesPluginTest to use JUnit
• db76f47: 8347720: [BACKOUT] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• e6902cf: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order
• a01e92c: 8347724: Replace SIZE_FORMAT in jfr directory
• d002933: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• d532019: 8347143: [aix] Fix strdup use in os::dll_load
• dfd215b: 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
• ... and 269 more: https://git.openjdk.org/jdk/compare/db9eab3f29e9cb26a8c0a7c31c55aaf140f21bed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dwhite-intel @IvaVladimir Pushed as commit 10d08db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.