8346139: test_memset_with_concurrent_readers.cpp should not use <sstream>

[kimbarrett]

Please review this change to test_memset_with_concurrent_readers.cpp to use
HotSpot's stringStream instead of std::string_stream to build the error
message when a failure is detected.

Also removed the include of <string.h>, which is one of the standard headers
we expect to be included by globalDefinitions.

Testing: mach5 tier1
Locally patched the test to fail and ran it, checking the output.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346139: test_memset_with_concurrent_readers.cpp should not use <sstream> (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22725/head:pull/22725
$ git checkout pull/22725

Update a local copy of the PR:
$ git checkout pull/22725
$ git pull https://git.openjdk.org/jdk.git pull/22725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22725

View PR using the GUI difftool:
$ git pr show -t 22725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22725.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346139: test_memset_with_concurrent_readers.cpp should not use <sstream>

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 367c304: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17
• 31ceec7: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04
• 09c29d1: 8346069: Add missing Classpath exception statements
• 28e49e9: 8345505: Fix -Wzero-as-null-pointer-constant warnings in zero code
• db9eab3: 8311542: Consolidate the native stack printing code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9266d6af)

[kimbarrett]

Thanks for reviews @stefank and @tschatzl

[kimbarrett]

/integrate

[openjdk]

Going to push as commit ebb27c2.
Since your change was applied there have been 14 commits pushed to the master branch:

• c2f0ef5: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635
• 4b21fb9: 8343467: Remove unnecessary @SuppressWarnings annotations (security)
• e7fc0eb: 8345987: java.management has two Util.newObjectName methods (remove one)
• f647d4d: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar
• cfa04d3: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled
• 2ce53e8: 8345970: pthread_getcpuclockid related crashes in shenandoah tests
• 266e3d0: 8345590: AIX 'make all' fails after JDK-8339480
• 1d2ccae: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64
• a9a5f7c: 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully
• 367c304: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17
• ... and 4 more: https://git.openjdk.org/jdk/compare/18e0b343ab002b193d4db3be226394ee7dbe9f19...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit ebb27c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.