Skip to content

Conversation

@LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Dec 13, 2024

Please review this trivial PR which removes (See below) which was missed during the SQLPermission update as part of the updates for JEP 486: Permanently Disable the Security Manager

I have confirmed there are no issues with the build via a macht tier1 run


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346202: Correct typo in SQLPermission (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22739/head:pull/22739
$ git checkout pull/22739

Update a local copy of the PR:
$ git checkout pull/22739
$ git pull https://git.openjdk.org/jdk.git pull/22739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22739

View PR using the GUI difftool:
$ git pr show -t 22739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22739.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346202: Correct typo in SQLPermission

Reviewed-by: mullan, rriggs, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e7fc0eb: 8345987: java.management has two Util.newObjectName methods (remove one)
  • f647d4d: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar
  • cfa04d3: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled
  • 2ce53e8: 8345970: pthread_getcpuclockid related crashes in shenandoah tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@LanceAndersen The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 13, 2024
@LanceAndersen LanceAndersen marked this pull request as ready for review December 13, 2024 19:58
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a jep486 label to the bug? Otherwise, looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2024
@LanceAndersen
Copy link
Contributor Author

Can you add a jep486 label to the bug? Otherwise, looks good.

Done, thank you Sean

@LanceAndersen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 15, 2024

Going to push as commit ab1dbd4.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 6b022bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
  • 3b9de11: 8319875: Add macOS implementation for jcmd System.map
  • ebb27c2: 8346139: test_memset_with_concurrent_readers.cpp should not use
  • c2f0ef5: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635
  • 4b21fb9: 8343467: Remove unnecessary @SuppressWarnings annotations (security)
  • e7fc0eb: 8345987: java.management has two Util.newObjectName methods (remove one)
  • f647d4d: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar
  • cfa04d3: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled
  • 2ce53e8: 8345970: pthread_getcpuclockid related crashes in shenandoah tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2024
@openjdk openjdk bot closed this Dec 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 15, 2024
@openjdk
Copy link

openjdk bot commented Dec 15, 2024

@LanceAndersen Pushed as commit ab1dbd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@LanceAndersen
Copy link
Contributor Author

/backport :jdk24

@openjdk
Copy link

openjdk bot commented Dec 15, 2024

@LanceAndersen the backport was successfully created on the branch backport-LanceAndersen-ab1dbd40-jdk24 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk24, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ab1dbd40 from the openjdk/jdk repository.

The commit being backported was authored by Lance Andersen on 15 Dec 2024 and was reviewed by Sean Mullan, Roger Riggs and Iris Clark.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-LanceAndersen-ab1dbd40-jdk24:backport-LanceAndersen-ab1dbd40-jdk24
$ git checkout backport-LanceAndersen-ab1dbd40-jdk24
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-LanceAndersen-ab1dbd40-jdk24

⚠️ @LanceAndersen You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants