-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346202: Correct typo in SQLPermission #22739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back lancea! A progress list of the required criteria for merging this PR into |
|
@LanceAndersen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@LanceAndersen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
seanjmullan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a jep486 label to the bug? Otherwise, looks good.
Done, thank you Sean |
|
/integrate |
|
Going to push as commit ab1dbd4.
Your commit was automatically rebased without conflicts. |
|
@LanceAndersen Pushed as commit ab1dbd4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport :jdk24 |
|
@LanceAndersen the backport was successfully created on the branch backport-LanceAndersen-ab1dbd40-jdk24 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk24, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
Please review this trivial PR which removes
(See below)which was missed during the SQLPermission update as part of the updates for JEP 486: Permanently Disable the Security ManagerI have confirmed there are no issues with the build via a macht tier1 run
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22739/head:pull/22739$ git checkout pull/22739Update a local copy of the PR:
$ git checkout pull/22739$ git pull https://git.openjdk.org/jdk.git pull/22739/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22739View PR using the GUI difftool:
$ git pr show -t 22739Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22739.diff
Using Webrev
Link to Webrev Comment