8337016: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM

[coleenp]

This increases MaxMetaspaceSize for this test so that it can be run with CDS turned off. This change is upstreamed from the valhalla repo from when it didn't have CDS on. The test still finds a metaspace leak with this larger MaxMetaspaceSize.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337016: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22746/head:pull/22746
$ git checkout pull/22746

Update a local copy of the PR:
$ git checkout pull/22746
$ git pull https://git.openjdk.org/jdk.git pull/22746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22746

View PR using the GUI difftool:
$ git pr show -t 22746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22746.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337016: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java gets Metaspace OOM

Reviewed-by: dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 18d1d61: 8346046: Enable copyright header format check
• a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
• 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
• 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
• fd0207d: 8345327: JDK 24 RDP1 L10n resource files update
• 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
• c75b1d4: 8346082: Output JVMTI agent information in hserr files
• 51662c2: 8346232: Remove leftovers of the jar --normalize feature
• d335941: 8345678: compute_modifiers should not be in create_mirror
• 57adf64: 8346261: Cleanup in JDP tests
• ... and 20 more: https://git.openjdk.org/jdk/compare/e7fc0eb522f14ee28ac40cf89268767cb7b6dfcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a1d529ff)
• 00: Full (f4d010ee)

[sspitsyn]

Looks good.

[coleenp]

Thank you for reviewing, David and Serguei.
/integrate

[openjdk]

Going to push as commit fbd76ca.
Since your change was applied there have been 39 commits pushed to the master branch:

• baeb3d9: 8346304: SA doesn't need a copy of getModifierFlags
• 99af595: 8345942: Separate source output from class output when building microbenchmarks
• 8a64595: 8346282: [JVMCI] Add failure reason support to UnresolvedJava/Type/Method/Field
• 725079b: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException
• 5e25c48: 8346289: Confusing phrasing in IR Framework README / User-defined Regexes
• fbbc7c3: 8346120: VirtualThreadPinned event recorded for Object.wait may have wrong duration or may record second event
• 466c00a: 8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI
• bd3c0be: 8268611: jar --validate should check targeted classes in MR-JAR files
• 87804f2: 8346294: Invalid lint category specified in compiler.properties
• 18d1d61: 8346046: Enable copyright header format check
• ... and 29 more: https://git.openjdk.org/jdk/compare/e7fc0eb522f14ee28ac40cf89268767cb7b6dfcf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit fbd76ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.