8346232: Remove leftovers of the jar --normalize feature

[eirbjo]

Please review this cleanup PR which removes a property and a code comment left behind after the jar --normalize feature was removed in JDK 14.

The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along with removal of Pack200 tools and APIs.

This PR removes the now unused main.help.opt.create.normalize property and a code comment in Main.java referencing normalization.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346232: Remove leftovers of the jar --normalize feature (Enhancement - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22751/head:pull/22751
$ git checkout pull/22751

Update a local copy of the PR:
$ git checkout pull/22751
$ git pull https://git.openjdk.org/jdk.git pull/22751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22751

View PR using the GUI difftool:
$ git pr show -t 22751

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22751.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346232: Remove leftovers of the jar --normalize feature

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

• dbffe33: 8345263: Make sure that lint categories are used correctly when logging lint warnings
• 32c8195: 8345801: C2: Clean up include statements to speed up compilation when touching type.hpp
• 9286018: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants
• 4fc43b0: 8345770: javadoc: API documentation builds are not always reproducible
• ee1c5ad: 8345975: Update SAP SE copyright year to 2024 where it was missed
• 3518b4b: 8344171: Clone and initialize Assertion Predicates in order instead of in reverse-order
• c88e081: 8346160: Fix -Wzero-as-null-pointer-constant warnings from explicit casts
• ab1dbd4: 8346202: Correct typo in SQLPermission
• 6b022bb: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
• 3b9de11: 8319875: Add macOS implementation for jcmd System.map
• ... and 73 more: https://git.openjdk.org/jdk/compare/165fd848c133e3281a13d55da77faa0641586b54...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@eirbjo The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e9bc7f0f)

[AlanBateman]

It does appear to be leftover from when the pack200 and the -n option were removed.

We don't usually touch the translated resources. Oracle updates the translations near the end of each release for the languages supported by Oracle JDK but there are a few translations that are probably out of date now. For removal then it's probably okay.

[eirbjo]

We don't usually touch the translated resources. [...] For removal then it's probably okay.

What's your recommendation here? Happy to revert changes to translated files, keeping the delete in jar.properties, if so desirable.

This would rely on Oracle's translation update process catching the remval and update it, ideally in all translations, not only those supported by Oracle JDK, right?

[AlanBateman]

What's your recommendation here? Happy to revert changes to translated files, keeping the delete in jar.properties, if so desirable.

This would rely on Oracle's translation update process catching the remval and update it, ideally in all translations, not only those supported by Oracle JDK, right?

I think what you have is okay, I'm just saying that we don't usually touch translations when making changes.

Oracle does a refresh the de, ja, and zh_CN translations in each release so I assume the lines you removed will get removed by the next update anyway. @justin-curtis-lu knows more about this "process". I don't know if anyone funds or maintains the other translations now, it's possible that some of these have bit rotted in recent years.

[justin-curtis-lu]

Yes, removing them is fine here. Otherwise we would have caught them during the L10n update anyways.

[jaikiran]

This looks fine to me.

[eirbjo]

Thanks for Alan and Jaikiran for reviews and to Justin for the L10n clarification.

/integrate

[openjdk]

Going to push as commit 51662c2.
Since your change was applied there have been 92 commits pushed to the master branch:

• d335941: 8345678: compute_modifiers should not be in create_mirror
• 57adf64: 8346261: Cleanup in JDP tests
• 23708d0: 8346257: Problemlist jdp tests for macosx-aarch64
• f8974ba: 8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test
• e7d21fc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
• cb92595: 8336356: [s390x] preserve Vector Register before using for string compress / expand
• d737978: 8343477: Remove unnecessary @SuppressWarnings annotations (compiler)
• 8133eb2: 8346150: Jib dependency on autoconf missing for 'docs' profile
• 45a3297: 8346248: serviceability/dcmd/vm/{SystemMapTest.java,SystemMapTest.java} failing on macos-aarch64
• dbffe33: 8345263: Make sure that lint categories are used correctly when logging lint warnings
• ... and 82 more: https://git.openjdk.org/jdk/compare/165fd848c133e3281a13d55da77faa0641586b54...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eirbjo Pushed as commit 51662c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.