Skip to content

Conversation

@LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Dec 15, 2024

Hi all,

This pull request contains a backport of commit [ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Lance Andersen on 15 Dec 2024 and was reviewed by Sean Mullan, Roger Riggs and Iris Clark.

Thanks!

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346202: Correct typo in SQLPermission (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22753/head:pull/22753
$ git checkout pull/22753

Update a local copy of the PR:
$ git checkout pull/22753
$ git pull https://git.openjdk.org/jdk.git pull/22753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22753

View PR using the GUI difftool:
$ git pr show -t 22753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22753.diff

Using Webrev

Link to Webrev Comment

@LanceAndersen LanceAndersen marked this pull request as ready for review December 15, 2024 17:48
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2024

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2024

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346202: Correct typo in SQLPermission

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab 8346202: Correct typo in SQLPermission Dec 15, 2024
@openjdk
Copy link

openjdk bot commented Dec 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Dec 15, 2024
@openjdk
Copy link

openjdk bot commented Dec 15, 2024

@LanceAndersen The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 15, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2024

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified matches change pushed to jdk 25.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2024
@LanceAndersen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit f703b6e.
Since your change was applied there have been 4 commits pushed to the jdk24 branch:

  • 297b21f: 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully
  • 67b8251: 8345944: JEP 492: extending local class in a different static context should not be allowed
  • 6e8aad1: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used
  • 4d6eccd: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@LanceAndersen Pushed as commit f703b6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants