Skip to content

8346257: Problemlist jdp tests for macosx-aarch64#22758

Closed
kevinjwalls wants to merge 2 commits intoopenjdk:masterfrom
kevinjwalls:8346257_problemlist_jdp
Closed

8346257: Problemlist jdp tests for macosx-aarch64#22758
kevinjwalls wants to merge 2 commits intoopenjdk:masterfrom
kevinjwalls:8346257_problemlist_jdp

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Dec 16, 2024

Fairly frequent failures on macosx-aarch64. For a while it was always on 15.0.1, but now also seen on "Mac OS X 12.7.1 (aarch64)", so this should be problemlisted for macosx-aarch64.

There are existing entries for aix, and the ProblemList file says it only wants one line per test.

Trivial change tested in CI which shows that sun/management/jdp/JdpOffTest.java still runs on macosx-aarch64.

Tests failing:
sun/management/jdp/JdpSpecificAddressTest.java
sun/management/jdp/JdpDefaultsTest.java
sun/management/jdp/JdpJmxRemoteDynamicPortTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346257: Problemlist jdp tests for macosx-aarch64 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22758/head:pull/22758
$ git checkout pull/22758

Update a local copy of the PR:
$ git checkout pull/22758
$ git pull https://git.openjdk.org/jdk.git pull/22758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22758

View PR using the GUI difftool:
$ git pr show -t 22758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22758.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346257: Problemlist jdp tests for macosx-aarch64

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@kevinjwalls To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@kevinjwalls
Copy link
Contributor Author

/label add serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@kevinjwalls
The serviceability label was successfully added.

@kevinjwalls kevinjwalls marked this pull request as ready for review December 16, 2024 10:29
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2024
@kevinjwalls
Copy link
Contributor Author

Thanks Chris!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

Going to push as commit 23708d0.
Since your change was applied there have been 44 commits pushed to the master branch:

  • f8974ba: 8345838: Remove the appcds/javaldr/AnonVmClassesDuringDump.java test
  • e7d21fc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
  • cb92595: 8336356: [s390x] preserve Vector Register before using for string compress / expand
  • d737978: 8343477: Remove unnecessary @SuppressWarnings annotations (compiler)
  • 8133eb2: 8346150: Jib dependency on autoconf missing for 'docs' profile
  • 45a3297: 8346248: serviceability/dcmd/vm/{SystemMapTest.java,SystemMapTest.java} failing on macos-aarch64
  • dbffe33: 8345263: Make sure that lint categories are used correctly when logging lint warnings
  • 32c8195: 8345801: C2: Clean up include statements to speed up compilation when touching type.hpp
  • 9286018: 8345322: RISC-V: Add concurrent gtests for cmpxchg variants
  • 4fc43b0: 8345770: javadoc: API documentation builds are not always reproducible
  • ... and 34 more: https://git.openjdk.org/jdk/compare/3f2556b86079fbdba848b1ac16b62a376386999b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2024
@openjdk openjdk bot closed this Dec 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@kevinjwalls Pushed as commit 23708d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants