Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Dec 16, 2024

The JVMCI UnresolvedJava/Type/Method/Field types can be used to represent resolution failures. It would be useful if an exception describing the resolution failure could be attached to these objects.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346282: [JVMCI] Add failure reason support to UnresolvedJava/Type/Method/Field (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22767/head:pull/22767
$ git checkout pull/22767

Update a local copy of the PR:
$ git checkout pull/22767
$ git pull https://git.openjdk.org/jdk.git pull/22767/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22767

View PR using the GUI difftool:
$ git pr show -t 22767

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22767.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346282: [JVMCI] Add failure reason support to UnresolvedJava/Type/Method/Field

Reviewed-by: never, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 87804f2: 8346294: Invalid lint category specified in compiler.properties
  • 18d1d61: 8346046: Enable copyright header format check
  • a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
  • 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
  • 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
  • fd0207d: 8345327: JDK 24 RDP1 L10n resource files update
  • 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
  • c75b1d4: 8346082: Output JVMTI agent information in hserr files
  • 51662c2: 8346232: Remove leftovers of the jar --normalize feature
  • d335941: 8345678: compute_modifiers should not be in create_mirror
  • ... and 7 more: https://git.openjdk.org/jdk/compare/45a329790b844139010c95f981c72ad43b08369a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Dec 16, 2024
@dougxc dougxc marked this pull request as ready for review December 16, 2024 16:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs


public UnresolvedJavaField(JavaType holder, String name, JavaType type) {
/**
* The reason method resolution failed. Can be null.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field resolution

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2024
Copy link
Contributor

@mur47x111 mur47x111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougxc
Copy link
Member Author

dougxc commented Dec 17, 2024

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

Going to push as commit 8a64595.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 725079b: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException
  • 5e25c48: 8346289: Confusing phrasing in IR Framework README / User-defined Regexes
  • fbbc7c3: 8346120: VirtualThreadPinned event recorded for Object.wait may have wrong duration or may record second event
  • 466c00a: 8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI
  • bd3c0be: 8268611: jar --validate should check targeted classes in MR-JAR files
  • 87804f2: 8346294: Invalid lint category specified in compiler.properties
  • 18d1d61: 8346046: Enable copyright header format check
  • a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
  • 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
  • 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
  • ... and 12 more: https://git.openjdk.org/jdk/compare/45a329790b844139010c95f981c72ad43b08369a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2024
@openjdk openjdk bot closed this Dec 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@dougxc Pushed as commit 8a64595.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants