-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8346282: [JVMCI] Add failure reason support to UnresolvedJava/Type/Method/Field #22767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
|
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
|
||
| public UnresolvedJavaField(JavaType holder, String name, JavaType type) { | ||
| /** | ||
| * The reason method resolution failed. Can be null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the reviews. /integrate |
|
Going to push as commit 8a64595.
Your commit was automatically rebased without conflicts. |
The JVMCI UnresolvedJava/Type/Method/Field types can be used to represent resolution failures. It would be useful if an exception describing the resolution failure could be attached to these objects.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22767/head:pull/22767$ git checkout pull/22767Update a local copy of the PR:
$ git checkout pull/22767$ git pull https://git.openjdk.org/jdk.git pull/22767/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22767View PR using the GUI difftool:
$ git pr show -t 22767Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22767.diff
Using Webrev
Link to Webrev Comment