8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI #22783

prsadhuk · 2024-12-17T07:44:11Z

javax/swing/JScrollBar/4865918/bug4865918.java fails in CI citing

java.lang.RuntimeException: The scrollbar block increment is incorrect
at bug4865918.main(bug4865918.java:60)

Seems like scrollbar is not in focus when mouse is pressed..Used CountDownLatch to mage focus gain more determinisitic.
Fix is passing in CI in several CI systems

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Abhishek Kumar (@kumarabhi006 - Reviewer) Review applies to 2eb13c95

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22783/head:pull/22783
$ git checkout pull/22783

Update a local copy of the PR:
$ git checkout pull/22783
$ git pull https://git.openjdk.org/jdk.git pull/22783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22783

View PR using the GUI difftool:
$ git pr show -t 22783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22783.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-12-17T07:45:06Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-12-17T07:45:19Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI

Reviewed-by: aivanov, abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 113 new commits pushed to the master branch:

8efc558: 8346378: Cannot use DllMain in libnet for static builds
73b5dba: 8345655: Move reservation code out of ReservedSpace
d50b725: 8344647: Make java.se participate in the preview language feature requires transitive java.base
9e8aa85: 8346017: Socket.connect specified to throw UHE for unresolved address is problematic for SOCKS V5 proxy
5b703c7: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI
edbd76c: 8344951: Stabilize write barrier micro-benchmarks
842f801: 8339331: GCC fortify error in vm_version_linux_aarch64.cpp
4533109: 8345911: Enhance error message when IncompatibleClassChangeError is thrown for sealed class loading failures
ea50c54: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
c0f0b8e: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest
... and 103 more: https://git.openjdk.org/jdk/compare/8de0622c3a5c9e01e79659ef0b43b1b01dfa5cf6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-12-17T07:46:10Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-12-17T07:49:42Z

Webrevs

aivanov-jdk

In the description you say, “scrollbar is not in focus when mouse is pressed.” Yet there's nothing in the test which handles the focus… even in the updated test.

However, I agree that your update makes the test more reliable, the latch guarantees the synthetic mouse event is handled before analysing the result.

So, it looks good exception for a couple of nits.

aivanov-jdk · 2024-12-17T13:06:13Z

test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java

+    private static volatile CountDownLatch latch;

    public static void main(String[] argv) throws Exception {
+        latch = new CountDownLatch(1);


Initialise the latch at its declaration.

Suggested change

private static volatile CountDownLatch latch;

public static void main(String[] argv) throws Exception {

latch = new CountDownLatch(1);

private static final CountDownLatch latch = new CountDownLatch(1);

public static void main(String[] argv) throws Exception {

mousePressLatch would be a more descriptive name.

aivanov-jdk · 2024-12-17T13:10:51Z

test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java

@@ -52,6 +56,7 @@ public static void main(String[] argv) throws Exception {
            robot.delay(1000);

            SwingUtilities.invokeAndWait(() -> sbar.pressMouse());
+            latch.await();


You should use timed await and throw an exception if the wait times out. This way the timeout would be handled more gracefully… and more quickly, a two-second timeout should be enough.

kumarabhi006

Seems good.

kumarabhi006 · 2024-12-18T06:32:02Z

test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java

@@ -34,14 +34,18 @@
 import javax.swing.JFrame;
 import javax.swing.JScrollBar;
 import javax.swing.SwingUtilities;
+import java.awt.event.MouseAdapter;


awt imports can be grouped together.

aivanov-jdk · 2024-12-18T12:45:45Z

test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java

@@ -56,7 +56,7 @@ public static void main(String[] argv) throws Exception {
            robot.delay(1000);

            SwingUtilities.invokeAndWait(() -> sbar.pressMouse());
-            latch.await();
+            mousePressLatch.await(2, TimeUnit.SECONDS);


Suggested change

mousePressLatch.await(2, TimeUnit.SECONDS);

if (!mousePressLatch.await(2, TimeUnit.SECONDS)) {

throw new RuntimeException("Timed out waiting for mouse press");

}

If you don't throw the exception, the test will continue to run… Yet we're sure it is likely to fail.

ok..modified..

prsadhuk · 2024-12-18T14:53:20Z

/integrate

openjdk · 2024-12-18T14:54:41Z

Going to push as commit a0b7c4f.
Since your change was applied there have been 113 commits pushed to the master branch:

8efc558: 8346378: Cannot use DllMain in libnet for static builds
73b5dba: 8345655: Move reservation code out of ReservedSpace
d50b725: 8344647: Make java.se participate in the preview language feature requires transitive java.base
9e8aa85: 8346017: Socket.connect specified to throw UHE for unresolved address is problematic for SOCKS V5 proxy
5b703c7: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI
edbd76c: 8344951: Stabilize write barrier micro-benchmarks
842f801: 8339331: GCC fortify error in vm_version_linux_aarch64.cpp
4533109: 8345911: Enhance error message when IncompatibleClassChangeError is thrown for sealed class loading failures
ea50c54: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
c0f0b8e: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest
... and 103 more: https://git.openjdk.org/jdk/compare/8de0622c3a5c9e01e79659ef0b43b1b01dfa5cf6...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-12-18T14:54:50Z

@prsadhuk Pushed as commit a0b7c4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

test fix

d33aa49

openjdk bot added the rfr Pull request is ready for review label Dec 17, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Dec 17, 2024

aivanov-jdk suggested changes Dec 17, 2024

View reviewed changes

Latch update

0befa72

kumarabhi006 reviewed Dec 18, 2024

View reviewed changes

import

2eb13c9

kumarabhi006 approved these changes Dec 18, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2024

aivanov-jdk suggested changes Dec 18, 2024

View reviewed changes

throw excpn

92c09af

openjdk bot removed the ready Pull request is ready to be integrated label Dec 18, 2024

aivanov-jdk approved these changes Dec 18, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2024

openjdk bot added the integrated Pull request has been integrated label Dec 18, 2024

openjdk bot closed this Dec 18, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2024

prsadhuk deleted the OCItest9 branch December 18, 2024 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI #22783

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI #22783

prsadhuk commented Dec 17, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Dec 17, 2024

openjdk bot commented Dec 17, 2024 •

edited

Loading

openjdk bot commented Dec 17, 2024

mlbridge bot commented Dec 17, 2024 •

edited

Loading

aivanov-jdk left a comment

aivanov-jdk Dec 17, 2024

aivanov-jdk Dec 17, 2024

prsadhuk Dec 18, 2024

kumarabhi006 left a comment

kumarabhi006 Dec 18, 2024

aivanov-jdk Dec 18, 2024

prsadhuk Dec 18, 2024

prsadhuk commented Dec 18, 2024

openjdk bot commented Dec 18, 2024

openjdk bot commented Dec 18, 2024

-            mousePressLatch.await(2, TimeUnit.SECONDS);
+            if (!mousePressLatch.await(2, TimeUnit.SECONDS)) {
+                throw new RuntimeException("Timed out waiting for mouse press");
+            }

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI #22783

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI #22783

Conversation

prsadhuk commented Dec 17, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Dec 17, 2024

openjdk bot commented Dec 17, 2024 • edited Loading

openjdk bot commented Dec 17, 2024

mlbridge bot commented Dec 17, 2024 • edited Loading

Webrevs

aivanov-jdk left a comment

Choose a reason for hiding this comment

aivanov-jdk Dec 17, 2024

Choose a reason for hiding this comment

aivanov-jdk Dec 17, 2024

Choose a reason for hiding this comment

prsadhuk Dec 18, 2024

Choose a reason for hiding this comment

kumarabhi006 left a comment

Choose a reason for hiding this comment

kumarabhi006 Dec 18, 2024

Choose a reason for hiding this comment

aivanov-jdk Dec 18, 2024

Choose a reason for hiding this comment

prsadhuk Dec 18, 2024

Choose a reason for hiding this comment

prsadhuk commented Dec 18, 2024

openjdk bot commented Dec 18, 2024

openjdk bot commented Dec 18, 2024

prsadhuk commented Dec 17, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Dec 17, 2024 •

edited

Loading

mlbridge bot commented Dec 17, 2024 •

edited

Loading