Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344611: Add missing classpath exception #22784

Conversation

Sorna-Sarathi
Copy link
Contributor

@Sorna-Sarathi Sorna-Sarathi commented Dec 17, 2024

Hi all,

This pull request contains a backport of commit 458979d8 from the openjdk/jdk repository.

The commit being backported was authored by Sorna Sarathi on 9 Dec 2024 and was reviewed by Amit Kumar and Iris Clark.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344611: Add missing classpath exception (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22784/head:pull/22784
$ git checkout pull/22784

Update a local copy of the PR:
$ git checkout pull/22784
$ git pull https://git.openjdk.org/jdk.git pull/22784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22784

View PR using the GUI difftool:
$ git pr show -t 22784

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22784.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back ssarathi! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@Sorna-Sarathi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344611: Add missing classpath exception

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the jdk24 branch:

  • f0ada9f: 8345327: JDK 24 RDP1 L10n resource files update
  • 303736b: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
  • 2c33629: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
  • 4aec2d4: 8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual
  • b8249c5: 8346017: Socket.connect specified to throw UHE for unresolved address is problematic for SOCKS V5 proxy
  • 0225372: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
  • 2cc14fa: 8344647: Make java.se participate in the preview language feature requires transitive java.base

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 458979d83ac784273263b54516369d79764010dd 8344611: Add missing classpath exception Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@Sorna-Sarathi The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

@kevinrushforth
Copy link
Member

@irisclark Can you review this backport?

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified changes are identical to those pushed earlier to master branch.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2024
@Sorna-Sarathi
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@Sorna-Sarathi
Your change (at version 5012376) is now ready to be sponsored by a Committer.

@irisclark
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

Going to push as commit bed0401.
Since your change was applied there have been 9 commits pushed to the jdk24 branch:

  • 5d138cb: 8345266: java/util/concurrent/locks/StampedLock/OOMEInStampedLock.java JTREG_TEST_THREAD_FACTORY=Virtual fails with OOME
  • 63aa68a: 8346128: Comparison build fails due to difference in LabelTarget.html
  • f0ada9f: 8345327: JDK 24 RDP1 L10n resource files update
  • 303736b: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
  • 2c33629: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
  • 4aec2d4: 8338714: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with JTREG_TEST_THREAD_FACTORY=Virtual
  • b8249c5: 8346017: Socket.connect specified to throw UHE for unresolved address is problematic for SOCKS V5 proxy
  • 0225372: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
  • 2cc14fa: 8344647: Make java.se participate in the preview language feature requires transitive java.base

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2024
@openjdk openjdk bot closed this Dec 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@irisclark @Sorna-Sarathi Pushed as commit bed0401.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants