Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346432: java.lang.foreign.Linker comment typo #22792

Closed
wants to merge 1 commit into from

Conversation

jankratochvil
Copy link
Contributor

@jankratochvil jankratochvil commented Dec 17, 2024

There are 2 typos and I find the API a bit complex so it does not help a new perplexed user of the API to be additionally confused by typos.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346432: java.lang.foreign.Linker comment typo (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22792/head:pull/22792
$ git checkout pull/22792

Update a local copy of the PR:
$ git checkout pull/22792
$ git pull https://git.openjdk.org/jdk.git pull/22792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22792

View PR using the GUI difftool:
$ git pr show -t 22792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22792.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346432: java.lang.foreign.Linker comment typo

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@jankratochvil The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

@jankratochvil
Copy link
Contributor Author

@JornVernee

Copy link
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2024
@jankratochvil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@jankratochvil
Your change (at version c2f74d9) is now ready to be sponsored by a Committer.

@minborg
Copy link
Contributor

minborg commented Dec 17, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

Going to push as commit a5503fb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2024
@openjdk openjdk bot closed this Dec 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@minborg @jankratochvil Pushed as commit a5503fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants