Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346463: Add test coverage for deploying the default provider as a module #22797

Closed
wants to merge 2 commits into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 17, 2024

test/jdk/java/nio/file/spi/SetDefaultProvider.java tests deploying with a custom file system provider as the default provider. The test is moved to JUnit and is updated with new tests that deploy the custom default provider on the module path. To support the different deployments, TestProvider is moved into a named package and module.

In preparation for JDK-8331467, a test is added to create a run-time image that contains the custom default file system provider.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346463: Add test coverage for deploying the default provider as a module (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22797/head:pull/22797
$ git checkout pull/22797

Update a local copy of the PR:
$ git checkout pull/22797
$ git pull https://git.openjdk.org/jdk.git pull/22797/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22797

View PR using the GUI difftool:
$ git pr show -t 22797

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22797.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346463: Add test coverage for deploying the default provider as a module

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 5db0a13: 8346132: fallbacklinker.c failed compilation due to unused variable
  • 5590669: 8346570: SM cleanup of tests for Beans and Serialization
  • c8e94ab: 8346532: XXXVector::rearrangeTemplate misses null check
  • f7f2b42: 8346300: Add @test annotation to TCKZoneId.test_constant_OLD_IDS_POST_2024b test
  • a0b7c4f: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI
  • 8efc558: 8346378: Cannot use DllMain in libnet for static builds
  • 73b5dba: 8345655: Move reservation code out of ReservedSpace
  • d50b725: 8344647: Make java.se participate in the preview language feature requires transitive java.base
  • 9e8aa85: 8346017: Socket.connect specified to throw UHE for unresolved address is problematic for SOCKS V5 proxy
  • 5b703c7: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI
  • ... and 8 more: https://git.openjdk.org/jdk/compare/4f44cf6bf2423a57a841be817f348e3b1e88f0eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 17, 2024
@AlanBateman AlanBateman marked this pull request as ready for review December 17, 2024 18:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all right to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2024
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

Going to push as commit 23d6f74.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 484229e: 8346306: Unattached thread can cause crash during VM exit if it calls wait_if_vm_exited
  • b0c40aa: 8340401: DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java fail with assert(_stack_base != nullptr) failed: Sanity check
  • 6b89954: 8346475: RISC-V: Small improvement for MacroAssembler::ctzc_bit
  • 00d8407: 8346016: Problemlist vm/mlvm/indy/func/jvmti/mergeCP_indy2manyDiff_a in virtual thread mode
  • 5db0a13: 8346132: fallbacklinker.c failed compilation due to unused variable
  • 5590669: 8346570: SM cleanup of tests for Beans and Serialization
  • c8e94ab: 8346532: XXXVector::rearrangeTemplate misses null check
  • f7f2b42: 8346300: Add @test annotation to TCKZoneId.test_constant_OLD_IDS_POST_2024b test
  • a0b7c4f: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI
  • 8efc558: 8346378: Cannot use DllMain in libnet for static builds
  • ... and 12 more: https://git.openjdk.org/jdk/compare/4f44cf6bf2423a57a841be817f348e3b1e88f0eb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2024
@openjdk openjdk bot closed this Dec 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2024
@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@AlanBateman Pushed as commit 23d6f74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants