8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE

[sspitsyn]

The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the specified FramePop event was already requested. This makes it consistent with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to add a breakpoint request that was already requested.

CSR: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE

Testing:

• tested with mach5 tiers 1-6

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8346462 to be approved

Issues

• JDK-8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE (Enhancement - P4)
• JDK-8346462: NotifyFramePop should return JVMTI_ERROR_DUPLICATE (CSR)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer) Review applies to 2468357f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22798/head:pull/22798
$ git checkout pull/22798

Update a local copy of the PR:
$ git checkout pull/22798
$ git pull https://git.openjdk.org/jdk.git pull/22798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22798

View PR using the GUI difftool:
$ git pr show -t 22798

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22798.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• db7fa6a: 8347289: HKDF delayed provider selection failed with non-extractable PRK
• 0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException
• ea49537: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
• 2e00816: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025
• 88fa3b2: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off
• 6ee2bd2: 8347147: [REDO] AccessFlags can be u2 in metadata
• a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
• 49ee4df: 8166983: Remove old/legacy unused tzdata files
• 3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
• 55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
• ... and 16 more: https://git.openjdk.org/jdk/compare/9702accdd9a25e05628d470bf248edd5d80c0c4d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sspitsyn The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (fbf9459d)
• 04: Full - Incremental (2468357f)
• 03: Full - Incremental (2b3fef1e)
• 02: Full - Incremental (defa6206)
• 01: Full - Incremental (4106c10a)
• 00: Full (57aa3bdb)

[alexmenkov]

I think we need a test for the functionality (a new one or update existing)

[sspitsyn]

Chris, thank you for review!

[sspitsyn]

Thank you for review, Alex!

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 2801bc6.
Since your change was applied there have been 39 commits pushed to the master branch:

• ceae2b9: 8347121: Add missing @serial tags to module java.base
• 8c87ea2: 8346478: RISC-V: Refactor add/sub assembler routines
• 765b9e6: 8346706: RISC-V: Add available registers to hs_err
• d66737e: 8341097: GHA: Demote Mac x86 jobs to build only
• dff5719: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
• 82e16ba: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
• 33f9be8: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests
• 8eddf67: 8346887: DrawFocusRect() may cause an assertion failure
• a46ae70: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
• 97dd06c: 8347299: Add annotations to test cases in LicenseTest
• ... and 29 more: https://git.openjdk.org/jdk/compare/9702accdd9a25e05628d470bf248edd5d80c0c4d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 2801bc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.