8344647: Make java.se participate in the preview language feature requires transitive java.base

[lahodaj]

Hi all,

This pull request contains a backport of commit d50b725a from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 18 Dec 2024 and was reviewed by Adam Sotona and Joe Darcy.

Thanks!

Description from the original PR:
There is a new preview language feature, requires transitive java.base;. And the java.se module is permitted to use the feature, without being marked as preview (i.e. the java.se module participates in preview). This is currently implemented by the common "participates in preview" way, by checking that java.base is exporting jdk.internal.javac package to java.se.

This common way works OK for internal preview feature and API usage, but turns out it may not be appropriate for this feature: the qualified export of the jdk.internal.javac package is not a specified API, it is an implementation detail; and the JLS itself specifies that the java.se module is participating in preview.

So this PR proposes to change the way javac handles the java.se module: it permits the use of the preview feature based on the module name, instead relying on the internal qualified export.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344647: Make java.se participate in the preview language feature requires transitive java.base (Bug - P3)

Reviewers

• Chen Liang (@liach - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22808/head:pull/22808
$ git checkout pull/22808

Update a local copy of the PR:
$ git checkout pull/22808
$ git pull https://git.openjdk.org/jdk.git pull/22808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22808

View PR using the GUI difftool:
$ git pr show -t 22808

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22808.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344647: Make java.se participate in the preview language feature `requires transitive java.base`

Reviewed-by: liach, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@lahodaj The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75911690)

[vicente-romero-oracle]

lgtm

[lahodaj]

/integrate

[openjdk]

Going to push as commit 2cc14fa.

[openjdk]

@lahodaj Pushed as commit 2cc14fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.